| commit | 5824a4ce1a0e47f3093128371c7156b35fe9d806 | [log] [tgz] |
|---|---|---|
| author | Daniel Martí <mvdan@mvdan.cc> | Fri Jun 12 15:14:42 2020 +0100 |
| committer | Daniel Martí <mvdan@mvdan.cc> | Thu Sep 24 20:27:51 2020 +0000 |
| tree | 6b63cd4b7d8cba88027eeaf9571589ec8a2b8c6a | |
| parent | 4cba6c703f68a7c1718e589feaeb2530d7812fbf [diff] |
cmd/go: error when -c or -i are used with unknown flags Other test flags passed to the test binary, such as -run or -count, are equally pointless when -c or -i are used, since the test binary is never run. However, custom flags in that scenario are far more likely to be due to human error, such as: # note the "ldflags" typo, which silently did nothing go test -c -lflags=-w Instead, make this scenario error. It seems unlikely that anyone is using -c along with intended custom-defined test flags, and if they are, removing those extra flags that do nothing is probably a good idea anyway. We don't add this restriction for the flags defined in 'go help testflag', since they are far less likely to be typos or unintended mistakes. Another reason not to do that change is that other commands similarly silently ignore no-op flags, such as: # -d disables the build, so -ldflags is never used go get -d -ldflags=-w Fixes #39484. Change-Id: I6ba2f6866562fe8f8fceaf4cd862d874bf5cd978 Reviewed-on: https://go-review.googlesource.com/c/go/+/237697 Trust: Daniel Martí <mvdan@mvdan.cc> Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.