net/http: preserve path escaping in redirects

Currently, when performing path sanitization and trailing-slash
redirects, we do not populate the RawPath field of the returned URL. As
a result, when a URL path is already escaped, our redirect behavior can
be rather surprising:

- When "/a//b%2fc" is sanitized, it is double-escaped, becoming
  "/a/b/%252fc".
- When doing trailing slash-redirect, "/a%2fb" will lose its escaping,
  becoming "/a/b/" instead of "/a%2fb/".

Fix this by populating the RawPath field.

Also updated TestServeWithSlashRedirectForHostPatterns that still uses
the old 301 status code rather than 307 after CL 720820.

Fixes #79897

Change-Id: Ibdd1f119afdd6824e52185be3852234a6a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/792860
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Nicholas Husin <husin@google.com>
2 files changed
tree: f2d722452cf6527c43b8a389af073b079cba4774
  1. .github/
  2. api/
  3. doc/
  4. lib/
  5. misc/
  6. src/
  7. test/
  8. .gitattributes
  9. .gitignore
  10. codereview.cfg
  11. CONTRIBUTING.md
  12. go.env
  13. LICENSE
  14. PATENTS
  15. README.md
  16. SECURITY.md
README.md

The Go Programming Language

Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.

Gopher image Gopher image by Renee French, licensed under Creative Commons 4.0 Attribution license.

Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.

Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.

Download and Install

Binary Distributions

Official binary distributions are available at https://go.dev/dl/.

After downloading a binary release, visit https://go.dev/doc/install for installation instructions.

Install From Source

If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.

Contributing

Go is the work of thousands of contributors. We appreciate your help!

To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.

Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.