| commit | f5af1e83a526146a12af48df9d5c9851e24569d7 | [log] [tgz] |
|---|---|---|
| author | Daniel Martí <mvdan@mvdan.cc> | Thu Apr 21 14:00:26 2022 +0100 |
| committer | Daniel Martí <mvdan@mvdan.cc> | Thu Apr 21 21:07:15 2022 +0000 |
| tree | bc6ac394c5f6f19d59abdb877ad75abed41e1899 | |
| parent | 4d96c3cdadb7de81ced18eceaa906f35730523f4 [diff] |
cmd/gofmt: only resolve go/ast objects when needed go/parser will by default resolve objects as per the go/ast.Object type, which is then used by gofmt's rewrite and simplify flags. However, none of that is needed if neither of the flags is set, so we can avoid the work entirely for a nice speed-up. benchcmd -n 8 GofmtSrcCmd gofmt -l ~/tip/src/cmd name old time/op new time/op delta GofmtSrcCmd 957ms ± 7% 908ms ± 7% -5.12% (p=0.028 n=8+8) name old user-time/op new user-time/op delta GofmtSrcCmd 11.2s ± 1% 10.4s ± 1% -7.23% (p=0.001 n=7+7) name old sys-time/op new sys-time/op delta GofmtSrcCmd 325ms ±29% 286ms ±22% ~ (p=0.065 n=8+8) name old peak-RSS-bytes new peak-RSS-bytes delta GofmtSrcCmd 295MB ±17% 276MB ±15% ~ (p=0.328 n=8+8) See #46485. Change-Id: Iad1ae294953710c233f7837d7eb02e23d11c6185 Reviewed-on: https://go-review.googlesource.com/c/go/+/401454 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.