| commit | 489620d8787a988aea4a083803608b55703f78a6 | [log] [tgz] |
|---|---|---|
| author | Austin Clements <austin@google.com> | Fri Jun 23 17:54:39 2017 -0400 |
| committer | Austin Clements <austin@google.com> | Mon Jun 26 19:25:26 2017 +0000 |
| tree | a4d1240289826f495903b71b04d40ac72352f9be | |
| parent | 6d594342c6fbbdc3673748b00bb8f2faaf63a0a4 [diff] |
runtime: drain local runq when dedicated mark worker runs When the dedicated mark worker runs, the scheduler won't run on that P again until GC runs out of mark work. As a result, any goroutines in that P's local run queue are stranded until another P steals them. In a normally operating system this may take a long time, and in a 100% busy system, the scheduler never attempts to steal from another P. Fix this by draining the local run queue into the global run queue if the dedicated mark worker has run for long enough. We don't do this immediately upon scheduling the dedicated mark worker in order to avoid destroying locality if the mark worker runs for a short time. Instead, the scheduler delays draining the run queue until the mark worker gets its first preemption request (and otherwise ignores the preemption request). Fixes #20011. Change-Id: I13067194b2f062b8bdef25cb75e4143b7fb6bb73 Reviewed-on: https://go-review.googlesource.com/46610 Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rick Hudson <rlh@golang.org>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Go is the work of hundreds of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project does not use GitHub pull requests, and that we use the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.