| commit | 37f9a8f69d6299783eac8848d87e27eb563500ac | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Thu Jun 24 11:01:49 2021 -0400 |
| committer | Robert Findley <rfindley@google.com> | Fri Jun 25 01:08:06 2021 +0000 |
| tree | bf383070890e408a827a73df6ab4c58bd86574a9 | |
| parent | c309c89db5aa15e1dad486c49ed4fd1babd23360 [diff] |
go/types: fix a bug in package qualification logic CL 313035 had a bug, initializing pkgPathMap by walking the imported package being considered rather than check.pkg. Fix this, and enhance our tests to exercise this bug as well as other edge cases. Also fix error assertions in issues.src to not use quotation marks inside the error regexp. The check tests only matched the error regexp up to the first quotation mark. Fixes #46905 Change-Id: I6aa8eae4bec6495006a5c03fc063db0d66b44cd6 Reviewed-on: https://go-review.googlesource.com/c/go/+/330629 Trust: Robert Findley <rfindley@google.com> Trust: Robert Griesemer <gri@golang.org> Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://golang.org/doc/contribute.html.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.