testing: record a test's failure for -failfast after cleanup runs The -failfast flag stops a test binary from starting new tests after the first failure. When a test had a parallel subtest, its failure was recorded before its cleanup functions ran. A failure inside a t.Cleanup was therefore not counted, and -failfast kept starting new tests. Tests without a parallel subtest run their cleanup earlier and were unaffected. Record the failure after cleanup has run, so a cleanup failure counts for -failfast regardless of whether the test has a parallel subtest. Fixes #61034 Change-Id: Icea654cbaf3904936200566d7d7d72ca8ccc5958 GitHub-Last-Rev: e46ad5ad314c5cee2a835be3627f4a6455b81c32 GitHub-Pull-Request: golang/go#80165 Reviewed-on: https://go-review.googlesource.com/c/go/+/794541 Reviewed-by: Alan Donovan <adonovan@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attribution license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.