crypto/internal/cryptotest: parse go mod download JSON from stdout
FetchModule runs "go mod download -json" and unmarshals the result.
The JSON contract is on stdout, but the go command can also print
non-fatal diagnostics to stderr.
On Windows builders, a module cache write warning such as
go: writing go.mod cache: rename ... Access is denied.
can be printed while the command still succeeds and emits valid JSON.
Because FetchModule used CombinedOutput, that stderr text was mixed into
the JSON stream, causing json.Unmarshal to fail with "invalid character
'g' looking for beginning of value".
Capture stderr separately, parse only stdout, and include both streams
in failure messages. Log stderr on successful downloads so the warning
is still visible without corrupting the JSON output.
Fixes #79954.
Fixes #79956.
Cq-Include-Trybots: luci.golang.try:gotip-windows-amd64-longtest
Change-Id: I21032da33cb0009e0eaf557903880d0188c18f4b
Reviewed-on: https://go-review.googlesource.com/c/go/+/793260
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Daniel McCarney <daniel@binaryparadox.net>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attribution license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.