| commit | 2c296dc8acb19753c187dacc046fc2193dedcf06 | [log] [tgz] |
|---|---|---|
| author | Russ Cox <rsc@golang.org> | Wed Dec 13 19:47:32 2017 -0500 |
| committer | Russ Cox <rsc@golang.org> | Thu Dec 14 02:25:34 2017 +0000 |
| tree | 908159ea2c6b5f24bdec4b50901ef73db6307b07 | |
| parent | 0f3ab149ec41cd35a9f61f49ce17bbc5af02537e [diff] |
cmd/go: apply same per-package flags to compile and link of test If package strings has a particular set of gcflags, then the strings_test pseudo-package built as part of the test binary started inheriting the same flags in CL 81496, to fix #22831. Now the package main and final test binary link built as part of the strings test binary also inherit the same flags, to fix #22994. I am slightly uneasy about reusing package strings's flags for package main, but the alternative would be to introduce some kind of special case, which I'd be even more uneasy about. This interpretation preserves the Go 1.9 behavior of existing commands like: go test -c -ldflags=-X=mypkg.debugString=foo mypkg Fixes #22994. Change-Id: I9ab83bf1a9a6adae530a7715b907e709fd6c1b5d Reviewed-on: https://go-review.googlesource.com/83879 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Go is the work of hundreds of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project does not use GitHub pull requests, and that we use the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.