| commit | 2ab6d0172eb9112eba8c6e05a813e260985d20cf | [log] [tgz] |
|---|---|---|
| author | Michael Anthony Knyszek <mknyszek@google.com> | Thu Jan 17 20:05:20 2019 +0000 |
| committer | Michael Knyszek <mknyszek@google.com> | Wed Apr 10 22:00:03 2019 +0000 |
| tree | afb9d74aa4faa8ec80fd92b530bf763daf0f6ad2 | |
| parent | 512b3c63b7472d2baab881de4dbcbd0ab8e447ab [diff] |
runtime: throw if scavenge necessary during coalescing Currently when coalescing if two adjacent spans are scavenged, we subtract their sizes from memstats and re-scavenge the new combined span. This is wasteful however, since the realignment semantics make this case of having to re-scavenge impossible. In realign() inside of coalesce(), there was also a bug: on systems where physPageSize > pageSize, we wouldn't realign because a condition had the wrong sign. This wasteful re-scavenging has been masking this bug this whole time. So, this change fixes that first. Then this change gets rid of the needsScavenge logic and instead checks explicitly for the possibility of unscavenged pages near the physical page boundary. If the possibility exists, it throws. The intent of throwing here is to catch changes to the runtime which cause this invariant to no longer hold, at which point it would likely be appropriate to scavenge the additional pages (and only the additional pages) at that point. Change-Id: I185e3d7b53e36e90cf9ace5fa297a9e8008d75f3 Reviewed-on: https://go-review.googlesource.com/c/go/+/158377 Run-TryBot: Michael Knyszek <mknyszek@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Austin Clements <austin@google.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.