| commit | 24925c7ed9da15fe780d0d2fce21bbaa707e8751 | [log] [tgz] |
|---|---|---|
| author | Giovanni Bajo <rasky@develer.com> | Mon Mar 23 09:21:44 2020 +0100 |
| committer | Giovanni Bajo <rasky@develer.com> | Mon Mar 23 17:47:29 2020 +0000 |
| tree | 3e985653337a8feb00921ccc7bea81c7562e3b96 | |
| parent | 5d47f870a64982173f3da8a82a6a793b83075d6a [diff] |
cmd/compile: fold LEAQ with constant scale into LEA Discovered this after rebasing CL196679 (use poset bounds in prove). Some tests fail with that CL applied: codegen/smallintiface.go:11: linux/amd64/: opcode not found: "^LEAQ\\truntime.staticuint64s\\+8\\(SB\\)" codegen/smallintiface.go:16: linux/amd64/: opcode not found: "^LEAQ\\truntime.staticuint64s\\+2024\\(SB\\)" codegen/smallintiface.go:21: linux/amd64/: opcode not found: "^LEAQ\\truntime.staticuint64s\\+24\\(SB\\)" The only difference in prove SSA dumps is that a single Lsh64x64 op with constant shift (<< 3) is marked as bounded. This triggers a different rule matching sequence in lower, which manages to generate worse code for the above testcases. This CL fixes the above test after CL196679 is applied. Right now, these rules never trigger (this CL passes toolstash -cmp), so I can't write a test. Change-Id: I353f1c79c1875cac1da82cd8afa1e05e42684f1c Reviewed-on: https://go-review.googlesource.com/c/go/+/224877 Run-TryBot: Giovanni Bajo <rasky@develer.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.