commit 2417b0d0067b192e7cca05c00d9874617607fa81
author Joel Sing <joel@sing.id.au> Wed Apr 24 22:21:53 2019 +1000
committer Brad Fitzpatrick <bradfitz@golang.org> Wed Apr 24 16:17:27 2019 +0000
tree 5d64c79a7cdd868e0e0557f2b6dbbd42111ad010
parent f84d28b7755f256efda7830a3b78b46464497527

cmd: re-enable tests with external linking on openbsd/arm

Go on openbsd/arm has supported external linking for a while now, so
re-enable the external linking related tests that were previously
disabled.

Fixes #10619

Change-Id: I304eeabf3b462d53b7feda17ae390bbe2fa22069
Reviewed-on: https://go-review.googlesource.com/c/go/+/173597
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

src/cmd/go/note_test.go

diff --git a/src/cmd/go/note_test.go b/src/cmd/go/note_test.go
index 66c5d39..6d3b9b8 100644
--- a/src/cmd/go/note_test.go
+++ b/src/cmd/go/note_test.go
@@ -32,8 +32,6 @@
 	switch {
 	case !build.Default.CgoEnabled:
 		t.Skipf("skipping - no cgo, so assuming external linking not available")
-	case runtime.GOOS == "openbsd" && runtime.GOARCH == "arm":
-		t.Skipf("skipping - external linking not supported, golang.org/issue/10619")
 	case runtime.GOOS == "plan9":
 		t.Skipf("skipping - external linking not supported")
 	}

src/cmd/objdump/objdump_test.go

diff --git a/src/cmd/objdump/objdump_test.go b/src/cmd/objdump/objdump_test.go
index be9fe52..0ac1d16 100644
--- a/src/cmd/objdump/objdump_test.go
+++ b/src/cmd/objdump/objdump_test.go
@@ -194,10 +194,6 @@
 	case "s390x":
 		t.Skipf("skipping on %s, issue 15255", runtime.GOARCH)
 	}
-	// TODO(jsing): Reenable once openbsd/arm has external linking support.
-	if runtime.GOOS == "openbsd" && runtime.GOARCH == "arm" {
-		t.Skip("skipping on openbsd/arm, no support for external linking, issue 10619")
-	}
 	if !build.Default.CgoEnabled {
 		t.Skip("skipping because cgo is not enabled")
 	}