| commit | 1962dc88eb89cd37d3f9f85e8e4b7ad4915db089 | [log] [tgz] |
|---|---|---|
| author | Raghavendra Nagaraj <jamdagni86@gmail.com> | Tue Jun 18 08:30:24 2019 +0000 |
| committer | Emmanuel Odeke <emm.odeke@gmail.com> | Wed Jun 19 05:46:46 2019 +0000 |
| tree | 53a341fcb6dc766883e226ae409e7986187fbb97 | |
| parent | c82e7e7a88aff4278a4816c35ae5354d984a24ac [diff] |
net/http: fix Server.IdleTimeout and Server.ReadHeaderTimeout docs CL 46434 changed the doc for Server.IdleTimeout to include falling back to Server.ReadHeaderTimeout if both Server.IdleTimeout and Server.ReadTimeout are zero. However, we explicitly set the ReadDeadlines firstly based off Server.IdleTimeout or Server.ReadTimeout before attempting to read the next request, thus the current doc is incorrect. This CL reverts CL 46434 and also updates the doc for Server.ReadHeaderTimeout to documenting falling back to Server.ReadTimeout, if the former is zero, otherwise there is no timeout. Fixes #32053 Change-Id: I43dd0252d1bcee6c29a8529abd84c84a49b2fba9 GitHub-Last-Rev: e1cdb599772476e0b52d9d2374c3ea3893844eb4 GitHub-Pull-Request: golang/go#32164 Reviewed-on: https://go-review.googlesource.com/c/go/+/178337 Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.