net/http/internal/http2: do some follow-ups to serve parking change

Fix a rebase comment mishap: the doc comment describing canPark was attached
to the http2serveparking var, leaving canPark undocumented.

Skip the parkMu accounting in beginServeSend and endServeSend on
connections that can never park (no OnClose hook, or parking disabled
with GODEBUG=http2serveparking=0), removing a mutex round trip per
frame on both the sender and receiver side.

Add a test that a response blocked on the peer's flow control window
parks the serve goroutine with its DATA queued in the write scheduler,
and that a WINDOW_UPDATE revives it.

Updates #80735
Updates #81524

Change-Id: Ic1a3f7b9d2e5a4c8f6b0d7a9e3c5f2b8d1a6e4c7
Reviewed-on: https://go-review.googlesource.com/c/go/+/832504
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Nicholas Husin <husin@google.com>
Reviewed-by: Nicholas Husin <nsh@golang.org>
2 files changed
tree: d84c93a484fbca3319d5aae0e4b09b9bbad7f9e9
  1. .github/
  2. api/
  3. doc/
  4. lib/
  5. misc/
  6. src/
  7. test/
  8. .gitattributes
  9. .gitignore
  10. codereview.cfg
  11. CONTRIBUTING.md
  12. go.env
  13. LICENSE
  14. PATENTS
  15. README.md
  16. SECURITY.md
README.md

The Go Programming Language

Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.

Gopher image Gopher image by Renee French, licensed under Creative Commons 4.0 Attribution license.

Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.

Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.

Download and Install

Binary Distributions

Official binary distributions are available at https://go.dev/dl/.

After downloading a binary release, visit https://go.dev/doc/install for installation instructions.

Install From Source

If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.

Contributing

Go is the work of thousands of contributors. We appreciate your help!

To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.

Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.