errors/fmt: change format of detail printing
Every line after the first message now has
some whitespace as prefix.
This should make it easier for loggers such
as Logstash and Splunk to detect a single
logged error.
See https://gist.github.com/carlpett/bc1714060235edc0ad3fd9ead82f4ce6.
Change-Id: Ifb35dad6d82454ad3e49d4905132110ff4d9324e
Reviewed-on: https://go-review.googlesource.com/c/147797
Run-TryBot: Marcel van Lohuizen <mpvl@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
diff --git a/errors/fmt/errors.go b/errors/fmt/errors.go
index 5e68180..a94ba3e 100644
--- a/errors/fmt/errors.go
+++ b/errors/fmt/errors.go
@@ -104,7 +104,7 @@
return false
case p.fmt.plusV:
- sep = "\n--- "
+ sep = "\n - "
w.fmt.fmtFlags = fmtFlags{plusV: p.fmt.plusV} // only keep detail flag
// The width or precision of a detailed view could be the number of
diff --git a/errors/fmt/errors_test.go b/errors/fmt/errors_test.go
index 57b7f2b..ff7e661 100644
--- a/errors/fmt/errors_test.go
+++ b/errors/fmt/errors_test.go
@@ -113,7 +113,7 @@
fmt: "%+v",
want: "can't adumbrate elephant:" +
"\n somefile.go:123" +
- "\n--- out of peanuts:" +
+ "\n - out of peanuts:" +
"\n the elephant is on strike" +
"\n and the 12 monkeys" +
"\n are laughing",
@@ -122,7 +122,7 @@
fmt: "%+v",
want: "elephant still on strike:" +
"\n somefile.go:123" +
- "\n--- out of peanuts:" +
+ "\n - out of peanuts:" +
"\n the elephant is on strike" +
"\n and the 12 monkeys" +
"\n are laughing",
@@ -151,7 +151,7 @@
// Note: no colon after the last error, as there are no details.
want: "fallback:" +
"\n somefile.go:123" +
- "\n--- file does not exist",
+ "\n - file does not exist",
}, {
err: opaque,
fmt: "%s",
@@ -161,9 +161,9 @@
fmt: "%+v",
want: "outer:" +
"\n somefile.go:123" +
- "\n--- mid:" +
+ "\n - mid:" +
"\n somefile.go:123" +
- "\n--- inner:" +
+ "\n - inner:" +
"\n somefile.go:123",
}, {
err: oldAndNew,
@@ -181,7 +181,7 @@
// implementation of the old-style error.
want: "new style:" +
"\n somefile.go:123" +
- "\n--- old style:" +
+ "\n - old style:" +
"\n otherfile.go:456",
}, {
err: simple,
diff --git a/errors/fmt/format_example_test.go b/errors/fmt/format_example_test.go
index c549cc8..e76907d 100644
--- a/errors/fmt/format_example_test.go
+++ b/errors/fmt/format_example_test.go
@@ -31,10 +31,10 @@
// foo:
// golang.org/x/exp/errors/fmt_test.foo
// golang.org/x/exp/errors/fmt/format_example_test.go:17
- // --- bar(nameserver 139):
+ // - bar(nameserver 139):
// golang.org/x/exp/errors/fmt_test.bar
// golang.org/x/exp/errors/fmt/format_example_test.go:16
- // --- baz flopped:
+ // - baz flopped:
// golang.org/x/exp/errors/fmt_test.baz
// golang.org/x/exp/errors/fmt/format_example_test.go:15
}
