commit | 7b3493d9a819351163c6cba79b7c05858d6ab15e | [log] [tgz] |
---|---|---|
author | Maxime Soulé <btik-git@scoubidou.com> | Tue Aug 08 11:06:49 2023 +0200 |
committer | Gopher Robot <gobot@golang.org> | Wed Aug 09 15:07:35 2023 +0000 |
tree | b107036e525e590016515fffae3e57e66bb54e29 | |
parent | 853ea248256d89ff7815cf4ae1ce2efa8bbb6277 [diff] |
jsonrpc2: do not panic when sending unmarshalable params If params given to (*Connection).Call is not JSON-marshalable, Call returns immediately an *AsyncCall instance containing the corresponding error, but its ctx field is not initialized. This produces a panic later in golang.org/x/exp/event.New, as it does not expect a nil context.Context. Fixes golang/go#61654. Change-Id: I6464ab5fde85670267b25821e0b57af04c331c8c Reviewed-on: https://go-review.googlesource.com/c/exp/+/516556 Reviewed-by: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Michael Knyszek <mknyszek@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> Auto-Submit: Bryan Mills <bcmills@google.com>
This subrepository holds experimental and deprecated (in the old
directory) packages.
The idea for this subrepository originated as the pkg/exp
directory of the main repository, but its presence there made it unavailable to users of the binary downloads of the Go installation. The subrepository has therefore been created to make it possible to go get
these packages.
Warning: Packages here are experimental and unreliable. Some may one day be promoted to the main repository or other subrepository, or they may be modified arbitrarily or even disappear altogether.
In short, code in this subrepository is not subject to the Go 1 compatibility promise. (No subrepo is, but the promise is even more likely to be violated by go.exp than the others.)
Caveat emptor.