notary/internal/note: allow Open to be passed known==nil
Better to handle it than crash.
Change-Id: Ied05cde9a812ad4229e9af36b9143f4430e1fbe4
Reviewed-on: https://go-review.googlesource.com/c/exp/+/172411
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
diff --git a/notary/internal/note/note.go b/notary/internal/note/note.go
index 0d04f67..ddb43f7 100644
--- a/notary/internal/note/note.go
+++ b/notary/internal/note/note.go
@@ -527,6 +527,11 @@
// Open returns an UnverifiedNoteError.
// In this case, the unverified note can be fetched from inside the error.
func Open(msg []byte, known Verifiers) (*Note, error) {
+ if known == nil {
+ // Treat nil Verifiers as empty list, to produce useful error instead of crash.
+ known = VerifierList()
+ }
+
// Must have valid UTF-8 with no non-newline ASCII control characters.
for i := 0; i < len(msg); {
r, size := utf8.DecodeRune(msg[i:])
