commit 6eba3985881e9b75278858dfb1c632b4f387a87d
author Keith Randall <keithr@alum.mit.edu> Wed Jan 17 14:13:45 2018 -0800
committer Keith Randall <khr@golang.org> Thu Jan 18 18:21:12 2018 +0000
tree 2dbd6ac5090523eab88679a7562b49e02b703348
parent 0d8c151b9558035bd164c2e4445f1b8ce4c54925

x/debug: more robust core dump handling

Handle cases where the core dump is incomplete by treating
the incomplete memory as read-as-zero.

1. Memory just isn't in the core dump (MADV_DONTDUMP).
2. Files referenced by the core dump aren't found.

Both of these occur with real dumps and we'd like to not make
these errors fatal. Often the client can make progress regardless.
Instead, export warning strings so clients can print them.

Change-Id: I0fdb6bb26f3c1b27bf68f63f835994e4c0de4fdd
Reviewed-on: https://go-review.googlesource.com/88155
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Peter Weinberger <pjw@google.com>