| commit | c889ad8cba24ab0567f86e146a6e8570a36dfbce | [log] [tgz] |
|---|---|---|
| author | Michael Pratt <mpratt@google.com> | Wed Aug 31 16:24:14 2022 -0400 |
| committer | Gopher Robot <gobot@golang.org> | Tue Sep 06 21:51:00 2022 +0000 |
| tree | dfdca9558ccc30a56d30b4b8d28254a60bfe9c3f | |
| parent | a55916e3aebb1522cb5b07706d7e8df21aaee510 [diff] |
internal/gocore: remove Process.minorVersion An explicit minor version number was added fairly recently in https://go.dev/cl/321736. It seems like a nice simplification, but it complicates working with devel builds significantly. In particular, tests running via the coordinator (build.golang.org) have no discernable version, just "devel SHA1", breaking version parsing, and making it impossible to add a test for dynamically generated core files. Thus, we drop minorVersion and revert back to feature tests via the type system. There are two exceptions (both from 1.17) where the type system isn't sufficient to differentiate the specific features, so unfortunately we still need a heuristic to detect 1.17. Change-Id: I5f98418833ee4742f1fe84de10865e133c9866f6 Reviewed-on: https://go-review.googlesource.com/c/debug/+/427214 Run-TryBot: Michael Pratt <mpratt@google.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org> Auto-Submit: Michael Pratt <mpratt@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
This repository holds utilities and libraries for debugging Go programs.
WARNING! Please expect breaking changes and unstable APIs. Most of them are currently are at an early, experimental stage.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the debug repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/debug:” in the subject line, so it is easy to find.