commit 986d3313588aa5c68f1df95eac956f79cf3b2c01
author Sven Blumenstein <svbl@google.com> Wed Aug 24 15:36:42 2016 +0200
committer Han-Wen Nienhuys <hanwen@google.com> Wed Aug 24 15:16:49 2016 +0000
tree 406f7ef23819d3420463f8362929c3a804dfa537
parent b35ccbc95a0eaae49fb65c5d627cb7149ed8d1ab

crypto/ssh: keep user in ConnMetadata if NoClientAuth is used

The current behaviour of the crypto/ssh server implementation is to
remove the username from ConnMetadata if the connection is done without
authentication (NoClientAuth). This appears to be a bug.

This behaviour is different from other SSH server implementations like
for example Paramiko (Python) which keeps the username.

Additionally RFC4252 (https://www.ietf.org/rfc/rfc4252.txt) section
5 states the username has to be included in every USERAUTH message.

Change-Id: I27fa50db92eb535e90fe088453faa6f2a76ee31f
Reviewed-on: https://go-review.googlesource.com/27612
Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>