cmd/gorebuild: interpret Retry-After values as seconds The Retry-After header's delay-seconds form is expressed in seconds. Convert it to a time.Duration in seconds before GerritTarGz sleeps. Add a regression test for a 429 response with Retry-After: 2. Change-Id: I28bed367e1a6dcf12b3f8811c4b5e1dc0a95e8d2 Reviewed-on: https://go-review.googlesource.com/c/build/+/809020 Reviewed-by: Mark Freeman <mark@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
diff --git a/cmd/gorebuild/io.go b/cmd/gorebuild/io.go index 59acb15..bac06c8 100644 --- a/cmd/gorebuild/io.go +++ b/cmd/gorebuild/io.go
@@ -66,7 +66,7 @@ v, _ := strconv.Atoi(resp.Header.Get("Retry-After")) return nil, tooManyRequestsError{ errorText: err.Error(), - RetryAfter: time.Duration(v), + RetryAfter: time.Duration(v) * time.Second, } } else if resp.StatusCode/100 == 5 { // Consider a 5xx server response to possibly succeed later.
diff --git a/cmd/gorebuild/io_test.go b/cmd/gorebuild/io_test.go new file mode 100644 index 0000000..ef46831 --- /dev/null +++ b/cmd/gorebuild/io_test.go
@@ -0,0 +1,30 @@ +// Copyright 2026 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +package main + +import ( + "errors" + "net/http" + "net/http/httptest" + "testing" + "time" +) + +func TestGetRetryAfter(t *testing.T) { + s := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + w.Header().Set("Retry-After", "2") + w.WriteHeader(http.StatusTooManyRequests) + })) + defer s.Close() + + _, err := Get(nil, s.URL) + var e tooManyRequestsError + if !errors.As(err, &e) { + t.Fatalf("Get error = %v, want tooManyRequestsError", err) + } + if e.RetryAfter != 2*time.Second { + t.Fatalf("RetryAfter = %v, want 2s", e.RetryAfter) + } +}