dashboard: skip the "reboot" dist test on NetBSD due to disk space issues
The NetBSD builders apparently have a tiny filesystem.
And this test doesn't need to be run everywhere. A few builders is enough.
Fixes golang/go#30839
Change-Id: I60df10173112ef9957c0e4cd6d414a4c5efaa940
Reviewed-on: https://go-review.googlesource.com/c/build/+/167637
Reviewed-by: Bryan C. Mills <bcmills@google.com>
diff --git a/dashboard/builders.go b/dashboard/builders.go
index b3b8731..2d3223e 100644
--- a/dashboard/builders.go
+++ b/dashboard/builders.go
@@ -1678,17 +1678,27 @@
ShouldRunDistTest: noTestDir,
MaxAtOnce: 1,
})
+ netBSDDistTestPolicy := func(distTest string, isTry bool) bool {
+ // Skip the test directory (slow, and adequately
+ // covered by other builders), and skip the "reboot"
+ // test, which takes more disk space on /tmp than the
+ // NetBSD image had as of 2019-03-13. (Issue 30839)
+ if strings.HasPrefix(distTest, "test:") || distTest == "reboot" {
+ return false
+ }
+ return true
+ }
addBuilder(BuildConfig{
Name: "netbsd-amd64-8_0",
HostType: "host-netbsd-amd64-8_0",
- ShouldRunDistTest: noTestDir,
+ ShouldRunDistTest: netBSDDistTestPolicy,
MaxAtOnce: 1,
tryBot: explicitTrySet("sys"),
})
addBuilder(BuildConfig{
Name: "netbsd-386-8_0",
HostType: "host-netbsd-386-8_0",
- ShouldRunDistTest: noTestDir,
+ ShouldRunDistTest: netBSDDistTestPolicy,
MaxAtOnce: 1,
// This builder currently hangs in the “../test” phase of all.bash.
// (https://golang.org/issue/25206)
