dashboard: convert regabi builders to noregabi
Now that GOEXPERIMENT includes regabi by default, there is a need to
make sure that the non-regabi paths for the compiler and runtime
continue to function correctly (in case for some reason we need to
turn regabi off). Switch the *-regabi builders to "noregabi" builders,
so that we have test coverage for this scenario.
Updates golang/go#40724.
Change-Id: Id5c0d4fda2f56393992c90ace463674e86b941ee
Reviewed-on: https://go-review.googlesource.com/c/build/+/313071
Trust: Than McIntosh <thanm@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
diff --git a/dashboard/builders.go b/dashboard/builders.go
index 7bd3819..0a08178 100644
--- a/dashboard/builders.go
+++ b/dashboard/builders.go
@@ -1728,30 +1728,30 @@
},
})
addBuilder(BuildConfig{
- Name: "linux-amd64-regabi",
+ Name: "linux-amd64-noregabi",
HostType: "host-linux-buster",
- Notes: "builder with GOEXPERIMENT=regabi, see golang.org/issue/40724",
+ Notes: "builder with GOEXPERIMENT=noregabi, see golang.org/issue/40724",
buildsRepo: func(repo, branch, goBranch string) bool {
return repo == "go" && branch == "master"
},
env: []string{
"GO_DISABLE_OUTBOUND_NETWORK=1",
- "GOEXPERIMENT=regabi",
+ "GOEXPERIMENT=noregabi",
},
GoDeps: []string{
"89b44b4e2bb2f88474d6b8476f5c28ea2aea9b28", // A master commit from 2020/12/20, just before a merge into dev.regabi, before the GOEXPERIMENT is used anywhere
},
})
addBuilder(BuildConfig{
- Name: "windows-amd64-regabi",
+ Name: "windows-amd64-noregabi",
HostType: "host-windows-amd64-2016",
- Notes: "builder with GOEXPERIMENT=regabi, see golang.org/issue/40724",
+ Notes: "builder with GOEXPERIMENT=noregabi, see golang.org/issue/40724",
buildsRepo: func(repo, branch, goBranch string) bool {
return repo == "go" && branch == "master"
},
env: []string{
"GO_DISABLE_OUTBOUND_NETWORK=1",
- "GOEXPERIMENT=regabi",
+ "GOEXPERIMENT=noregabi",
"GOARCH=amd64",
"GOHOSTARCH=amd64",
// cmd/go takes ~188 seconds on windows-amd64
@@ -1765,16 +1765,16 @@
},
})
addBuilder(BuildConfig{
- Name: "darwin-amd64-regabi",
+ Name: "darwin-amd64-noregabi",
HostType: "host-darwin-10_15",
distTestAdjust: macTestPolicy,
- Notes: "builder with GOEXPERIMENT=regabi, see golang.org/issue/40724",
+ Notes: "builder with GOEXPERIMENT=noregabi, see golang.org/issue/40724",
buildsRepo: func(repo, branch, goBranch string) bool {
return repo == "go" && branch == "master"
},
env: []string{
"GO_DISABLE_OUTBOUND_NETWORK=1",
- "GOEXPERIMENT=regabi",
+ "GOEXPERIMENT=noregabi",
},
GoDeps: []string{
"89b44b4e2bb2f88474d6b8476f5c28ea2aea9b28", // A master commit from 2020/12/20, just before a merge into dev.regabi, before the GOEXPERIMENT is used anywhere
diff --git a/dashboard/builders_test.go b/dashboard/builders_test.go
index dbb4a1d..eac4a70 100644
--- a/dashboard/builders_test.go
+++ b/dashboard/builders_test.go
@@ -590,8 +590,8 @@
{b("linux-amd64-staticlockranking@go1.14", "go"), none},
{b("linux-amd64-staticlockranking", "net"), none},
- {b("linux-amd64-regabi", "go"), onlyPost},
- {b("linux-amd64-regabi", "net"), none},
+ {b("linux-amd64-noregabi", "go"), onlyPost},
+ {b("linux-amd64-noregabi", "net"), none},
}
for _, tt := range tests {
t.Run(tt.br.testName, func(t *testing.T) {
