commit d36eef7e29e5a51160492e873e956f0471c0cb9f
author Dmitri Shuralyov <dmitshur@golang.org> Fri May 14 17:41:43 2021 -0400
committer Dmitri Shuralyov <dmitshur@golang.org> Mon May 17 23:53:01 2021 +0000
tree ee76b53ecb52e3b29f24c51c214c99836944ae59
parent 39f255e9b946f71198d1e5b00db211013f85660c

maintner: log about loading unknown JSON only in verbose mode

We already log about storing unknown JSON (on the server) and can look
up occurrences there. Most clients don't care, so only log if they are
in verbose mode.

Fixes golang/go#46180.

Change-Id: I665511e3d69827108bf59ddcd5e44359cacbaaa2
Reviewed-on: https://go-review.googlesource.com/c/build/+/320290
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>

maintner/github.go

diff --git a/maintner/github.go b/maintner/github.go
index 18ecf2f..04c20f4 100644
--- a/maintner/github.go
+++ b/maintner/github.go
@@ -222,6 +222,10 @@
 	return lb
 }
 
+func (g *GitHubRepo) verbose() bool {
+	return g.github != nil && g.github.c != nil && g.github.c.verbose
+}
+
 // GitHubUser represents a GitHub user.
 // It is a subset of https://developer.github.com/v3/users/#get-a-single-user
 type GitHubUser struct {
@@ -550,7 +554,9 @@
 	if len(p.OtherJson) > 0 {
 		// TODO: parse it and see if we've since learned how
 		// to deal with it?
-		log.Printf("Unknown JSON in log: %s", p.OtherJson)
+		if r.verbose() {
+			log.Printf("newGithubReview: unknown JSON in log: %s", p.OtherJson)
+		}
 		e.OtherJSON = string(p.OtherJson)
 	}
 
@@ -702,7 +708,9 @@
 	if len(p.OtherJson) > 0 {
 		// TODO: parse it and see if we've since learned how
 		// to deal with it?
-		log.Printf("Unknown JSON in log: %s", p.OtherJson)
+		if r.verbose() {
+			log.Printf("newGithubEvent: unknown JSON in log: %s", p.OtherJson)
+		}
 		e.OtherJSON = string(p.OtherJson)
 	}
 	if p.Label != nil {
@@ -985,10 +993,6 @@
 	b  *github.Issue // may NOT be nil
 }
 
-func (d githubIssueDiffer) verbose() bool {
-	return d.gr.github != nil && d.gr.github.c != nil && d.gr.github.c.verbose
-}
-
 // returns nil if no changes.
 func (d githubIssueDiffer) Diff() *maintpb.GithubIssueMutation {
 	var changed bool
@@ -1000,7 +1004,7 @@
 	}
 	for _, f := range issueDiffMethods {
 		if f(d, m) {
-			if d.verbose() {
+			if d.gr.verbose() {
 				fname := strings.TrimPrefix(runtime.FuncForPC(reflect.ValueOf(f).Pointer()).Name(), "golang.org/x/build/maintner.githubIssueDiffer.")
 				log.Printf("Issue %d changed: %v", d.b.GetNumber(), fname)
 			}