commit cef3db4d560b61d52cab729d21aeb2d678d22e64
author Michael Anthony Knyszek <mknyszek@google.com> Tue Jan 31 17:39:52 2023 +0000
committer Michael Knyszek <mknyszek@google.com> Tue Jan 31 18:41:00 2023 +0000
tree 4e83930a76763fed0095e9a59efb48eaae33b2a3
parent 44974d27f450fbc60816e91378c3c99649daf356

perf: replace regression page issue links with emojis for good results

Also fixes the higher is better logic for this page. Oops.

Change-Id: I27aa263526bd2be39f0ca55248e35b4b2cc672d8
Reviewed-on: https://go-review.googlesource.com/c/build/+/464356
Run-TryBot: Michael Knyszek <mknyszek@google.com>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>

perf/app/dashboard/index.html

diff --git a/perf/app/dashboard/index.html b/perf/app/dashboard/index.html
index f0a20f9..a9b1f13 100644
--- a/perf/app/dashboard/index.html
+++ b/perf/app/dashboard/index.html
@@ -165,16 +165,25 @@
 				const regression = (Math.abs(r.Change)*100).toFixed(2);
 				const shortCommit = rd.CommitHash.slice(0, 7);
 				let diffText = "regression";
-				if ((bench.HigherIsBetter && r.Change < 0) || (bench.HigherIsBetter && r.Change > 0)) {
+				let isRegression = true;
+				if (r.Change < 0) {
+					// Note: r.Change already has its sign flipped for HigherIsBetter.
+					// Positive always means regression, negative always means improvement.
 					diffText = "improvement";
+					isRegression = false;
 				}
 				p.innerHTML = `${regression}% ${diffText}, ${(r.Delta*100).toFixed(2)}%-point change at <a href="?benchmark=${bench.Name}&unit=${bench.Unit}#${commitToId(rd.CommitHash)}">${shortCommit}</a>.`;
 
 				// Add a link to file a bug.
-				const title = `affected/package: ${regression}% regression in ${bench.Name} ${bench.Unit} at ${shortCommit}`;
-				const body = `Discovered a regression in ${bench.Unit} of ${regression}% for benchmark ${bench.Name} at ${shortCommit}.\n\n<ADD MORE DETAILS>.`
-				let query = `?title=${encodeURIComponent(title)}&body=${encodeURIComponent(body)}&labels=Performance`;
-				p.innerHTML += ` <a href="https://github.com/golang/go/issues/new${query}">File an issue</a>.`;
+				if (isRegression) {
+					const title = `affected/package: ${regression}% regression in ${bench.Name} ${bench.Unit} at ${shortCommit}`;
+					const body = `Discovered a regression in ${bench.Unit} of ${regression}% for benchmark ${bench.Name} at ${shortCommit}.\n\n<ADD MORE DETAILS>.`
+					let query = `?title=${encodeURIComponent(title)}&body=${encodeURIComponent(body)}&labels=Performance`;
+					p.innerHTML += ` <a href="https://github.com/golang/go/issues/new${query}">File an issue</a>.`;
+				} else {
+					// Include a grinning emoji if it's an improvement.
+					p.innerHTML += ` <span style="font-style: normal;">&#128513;</span>`;
+				}
 			} else {
 				p.textContext = `Not ranked because ${r.IgnoredBecause}.`;
 			}