devapp: show CLs containing DO NOT SUBMIT
Change https://dev.golang.org/reviews page to be more helpful
at displaying CLs that are in need of a general code review.
Don't hide CLs containing DO NOT SUBMIT. Per Interim Code Review
and Issue Tracker Conventions¹:
DO NOT SUBMIT means that while the CL is okay to review,
the author wants Gerrit to make sure the CL is not submitted
in its current form.
That means we should not be excluding CLs containing DO NOT SUBMIT
from the reviews page.
Remove a log line from GerritMeta.LabelVotes method. It's not serving
a helpful purpose at this time, but produces a large amount of output.
¹ https://groups.google.com/d/msg/golang-dev/YU56eKYiXJg/K1CkXo7Iy0gJ
Change-Id: Ibe40f756e6a0dab0a13c75fa53998e2d56d287e3
Reviewed-on: https://go-review.googlesource.com/c/163159
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
diff --git a/devapp/reviews.go b/devapp/reviews.go
index c1b17d2..4644c16 100644
--- a/devapp/reviews.go
+++ b/devapp/reviews.go
@@ -116,8 +116,7 @@
p.ForeachOpenCL(func(cl *maintner.GerritCL) error {
if cl.WorkInProgress() ||
cl.Owner() == nil ||
- strings.Contains(cl.Commit.Msg, "DO NOT REVIEW") ||
- strings.Contains(cl.Commit.Msg, "DO NOT SUBMIT") {
+ strings.Contains(cl.Commit.Msg, "DO NOT REVIEW") {
return nil
}
tags := cl.Meta.Hashtags()
diff --git a/devapp/templates/reviews.tmpl b/devapp/templates/reviews.tmpl
index c131412..0bd7eff 100644
--- a/devapp/templates/reviews.tmpl
+++ b/devapp/templates/reviews.tmpl
@@ -54,7 +54,7 @@
<header>
<strong>{{.TotalChanges}} open changes</strong>
<div class="header-subtitle">
- Excluding those marked WIP, having hashtags "wait-author", "wait-release", or description containing "DO NOT REVIEW" or "DO NOT SUBMIT".
+ Excluding those marked WIP, having hashtags "wait-author", "wait-release", or description containing "DO NOT REVIEW".
</div>
<div class="header-subtitle">
<a href="https://go.googlesource.com/build/+/master/devapp/reviews.go">Source code</a>
diff --git a/maintner/gerrit.go b/maintner/gerrit.go
index b89609f..acf5f45 100644
--- a/maintner/gerrit.go
+++ b/maintner/gerrit.go
@@ -1443,7 +1443,6 @@
history := m.CL.Metas[:ourIndex+1]
var lastCommit string
for _, mc := range history {
- log.Printf("For CL %v, mc %v", m.CL.Number, mc)
footer := mc.Footer()
isNew := strings.Contains(footer, "\nTag: autogenerated:gerrit:newPatchSet\n")
email := mc.Commit.Author.Email()
