devapp: hide Work-In-Progress reviews
Fixes golang/go#27986
Change-Id: If9b1f5d705e225fd78464597624550fd6c1924ea
Reviewed-on: https://go-review.googlesource.com/c/139757
Reviewed-by: Katie Hockman <katie@golang.org>
diff --git a/devapp/reviews.go b/devapp/reviews.go
index 49ff148..965598e 100644
--- a/devapp/reviews.go
+++ b/devapp/reviews.go
@@ -114,7 +114,9 @@
s.corpus.Gerrit().ForeachProjectUnsorted(func(p *maintner.GerritProject) error {
proj := &project{GerritProject: p}
p.ForeachOpenCL(func(cl *maintner.GerritCL) error {
- if strings.Contains(cl.Commit.Msg, "DO NOT REVIEW") || strings.Contains(cl.Commit.Msg, "DO NOT SUBMIT") {
+ if cl.WorkInProgress() ||
+ strings.Contains(cl.Commit.Msg, "DO NOT REVIEW") ||
+ strings.Contains(cl.Commit.Msg, "DO NOT SUBMIT") {
return nil
}
tags := cl.Meta.Hashtags()
diff --git a/devapp/templates/reviews.tmpl b/devapp/templates/reviews.tmpl
index 5be749b..69a02bb 100644
--- a/devapp/templates/reviews.tmpl
+++ b/devapp/templates/reviews.tmpl
@@ -54,7 +54,7 @@
<header>
<strong>{{.TotalChanges}} open changes</strong>
<div class="header-subtitle">
- Excluding those with hashtags "wait-author", "wait-release", or description with “DO NOT REVIEW” or “DO NOT SUBMIT”
+ Excluding those marked WIP, having hashtags "wait-author", "wait-release", or description containing "DO NOT REVIEW" or "DO NOT SUBMIT".
</div>
<div class="header-subtitle">
<a href="https://go.googlesource.com/build/+/master/devapp/reviews.go">Source code</a>
