dashboard: remove stale "at least Go 1.16" checks
In this package, there are uses of atLeastGo1, MinimumGoVersion, GoDeps,
and addMiscCompileGo1 to prevent builds from running on Go commits that
don't meet the minimum Go version requirement.
At this point in time, Go 1.17 and 1.16 are the supported releases,
and coordinator doesn't test anything older. Remove various checks
from build policies that become redundant due to being always true.
Similarly, the misc-compile-darwinarm64 TryBot no longer needs to
be special, so we can divide misc-compile TryBot work more evenly.
Change-Id: I3a4804d18b1cdff1e46427cd8e73167aa18d8a35
Reviewed-on: https://go-review.googlesource.com/c/build/+/386115
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>
diff --git a/dashboard/builders.go b/dashboard/builders.go
index d81d23f..3435592 100644
--- a/dashboard/builders.go
+++ b/dashboard/builders.go
@@ -1574,11 +1574,7 @@
Name: "linux-386-softfloat",
Notes: "GO386=softfloat",
buildsRepo: func(repo, branch, goBranch string) bool {
- // GO386=softfloat is added in Go 1.16 (golang.org/issue/41848).
- return atLeastGo1(goBranch, 16) && (repo == "go" || repo == "crypto")
- },
- GoDeps: []string{
- "04b8a9fea57e37589d82410281f22ebde0027808", // CL 260017, "all: implement GO386=softfloat".
+ return repo == "go" || repo == "crypto"
},
HostType: "host-linux-stretch",
env: []string{"GOARCH=386", "GOHOSTARCH=386", "GO386=softfloat"},
@@ -1658,8 +1654,8 @@
// some misc-compile TryBot could become much slower than others.)
//
// See golang.org/issue/32632.
- addMiscCompile("-mac-win", "darwin-amd64", "windows-arm", "windows-arm64")
- addMiscCompileGo1(16, "-darwinarm64", "darwin-arm64") // darwin/arm64 (for Go 1.16 and newer) only.
+ addMiscCompile("-windows-arm", "windows-arm", "windows-arm64")
+ addMiscCompile("-darwin", "darwin-amd64", "darwin-arm64")
addMiscCompile("-mips", "linux-mips", "linux-mips64")
addMiscCompile("-mipsle", "linux-mipsle", "linux-mips64le")
addMiscCompile("-ppc", "linux-ppc64", "linux-ppc64le", "aix-ppc64")
@@ -1721,24 +1717,18 @@
"GO_DISABLE_OUTBOUND_NETWORK=1",
"GO_GCFLAGS=-d=ssa/check/on,dclstack",
},
- GoDeps: []string{
- "f65abf6ddc8d1f3d403a9195fd74eaffa022b07f", // adds dclstack
- },
})
addBuilder(BuildConfig{
Name: "linux-amd64-staticlockranking",
HostType: "host-linux-stretch",
Notes: "builder with GOEXPERIMENT=staticlockranking, see golang.org/issue/37937",
buildsRepo: func(repo, branch, goBranch string) bool {
- return repo == "go" && atLeastGo1(goBranch, 15)
+ return repo == "go"
},
env: []string{
"GO_DISABLE_OUTBOUND_NETWORK=1",
"GOEXPERIMENT=staticlockranking",
},
- GoDeps: []string{
- "02057906f7272a4787b8a0b5b7cafff8ad3024f0", // A master commit from 2020/03/19, just before CL 222925 and CL 207619 have landed.
- },
})
addBuilder(BuildConfig{
Name: "linux-amd64-unified",
@@ -1772,9 +1762,6 @@
env: []string{
"GO_DISABLE_OUTBOUND_NETWORK=1",
},
- GoDeps: []string{
- "22f1b56dab29d397d2bdbdd603d85e60fb678089", // adds cmd/compile -c; Issue 20222
- },
})
addBuilder(BuildConfig{
Name: "linux-amd64-race",
@@ -2107,11 +2094,8 @@
},
})
addBuilder(BuildConfig{
- Name: "netbsd-arm64-bsiegert",
- HostType: "host-netbsd-arm64-bsiegert",
- buildsRepo: func(repo, branch, goBranch string) bool {
- return atLeastGo1(goBranch, 16) && buildRepoByDefault(repo)
- },
+ Name: "netbsd-arm64-bsiegert",
+ HostType: "host-netbsd-arm64-bsiegert",
distTestAdjust: noTestDirAndNoReboot,
tryBot: nil,
env: []string{
@@ -2380,7 +2364,7 @@
tryBot: func(repo, branch, goBranch string) bool {
switch repo {
case "go", "mobile", "sys", "net", "tools", "crypto", "sync", "text", "time":
- return atLeastGo1(branch, 13) && atLeastGo1(goBranch, 13)
+ return true
}
return false
},
@@ -2403,9 +2387,8 @@
},
})
addBuilder(BuildConfig{
- Name: "illumos-amd64",
- HostType: "host-illumos-amd64-jclulow",
- MinimumGoVersion: types.MajorMinor{1, 13},
+ Name: "illumos-amd64",
+ HostType: "host-illumos-amd64-jclulow",
})
addBuilder(BuildConfig{
Name: "solaris-amd64-oraclerel",
@@ -2579,9 +2562,6 @@
distTestAdjust: noTestDirAndNoReboot,
env: []string{"GO_TEST_TIMEOUT_SCALE=2"}, // see golang.org/issue/45216
SkipSnapshot: true,
- buildsRepo: func(repo, branch, goBranch string) bool {
- return atLeastGo1(goBranch, 14) && buildRepoByDefault(repo)
- },
})
addBuilder(BuildConfig{
Name: "freebsd-arm-paulzhol",
@@ -2607,9 +2587,6 @@
addBuilder(BuildConfig{
Name: "freebsd-arm64-dmgk",
HostType: "host-freebsd-arm64-dmgk",
- buildsRepo: func(repo, branch, goBranch string) bool {
- return atLeastGo1(goBranch, 14) && buildRepoByDefault(repo)
- },
})
addBuilder(BuildConfig{
Name: "plan9-arm",
@@ -2646,9 +2623,8 @@
buildsRepo: plan9Default,
})
addBuilder(BuildConfig{
- Name: "aix-ppc64",
- HostType: "host-aix-ppc64-osuosl",
- MinimumGoVersion: types.MajorMinor{1, 12},
+ Name: "aix-ppc64",
+ HostType: "host-aix-ppc64-osuosl",
env: []string{
"PATH=/opt/freeware/bin:/usr/bin:/etc:/usr/sbin:/usr/ucb:/usr/bin/X11:/sbin:/usr/java7_64/jre/bin:/usr/java7_64/bin",
},
diff --git a/dashboard/builders_test.go b/dashboard/builders_test.go
index 9da652b..513d923 100644
--- a/dashboard/builders_test.go
+++ b/dashboard/builders_test.go
@@ -107,9 +107,9 @@
"windows-386-2012",
"windows-amd64-2016",
- "misc-compile-darwinarm64",
+ "misc-compile-darwin",
"misc-compile-freebsd",
- "misc-compile-mac-win",
+ "misc-compile-windows-arm",
"misc-compile-mips",
"misc-compile-mipsle",
"misc-compile-netbsd",
@@ -141,9 +141,9 @@
"windows-386-2012",
"windows-amd64-2016",
- "misc-compile-darwinarm64",
+ "misc-compile-darwin",
"misc-compile-freebsd",
- "misc-compile-mac-win",
+ "misc-compile-windows-arm",
"misc-compile-mips",
"misc-compile-mipsle",
"misc-compile-netbsd",
@@ -174,9 +174,9 @@
"windows-386-2012",
"windows-amd64-2016",
- "misc-compile-darwinarm64",
+ "misc-compile-darwin",
"misc-compile-freebsd",
- "misc-compile-mac-win",
+ "misc-compile-windows-arm",
"misc-compile-mips",
"misc-compile-mipsle",
"misc-compile-netbsd",
@@ -211,9 +211,9 @@
"windows-386-2012",
"windows-amd64-2016",
- "misc-compile-darwinarm64", // Starts with Go 1.16.
+ "misc-compile-darwin",
"misc-compile-freebsd",
- "misc-compile-mac-win",
+ "misc-compile-windows-arm",
"misc-compile-mips",
"misc-compile-mipsle",
"misc-compile-netbsd",
@@ -415,19 +415,13 @@
// Don't test all subrepos on all the builders.
{b("linux-amd64-ssacheck", "net"), none},
- {b("linux-amd64-ssacheck@go1.15", "net"), none},
+ {b("linux-amd64-ssacheck@go1.18", "net"), none},
{b("linux-386-softfloat", "crypto"), onlyPost},
- {b("linux-386-softfloat@go1.16", "crypto"), onlyPost},
- {b("linux-386-softfloat@go1.15", "crypto"), none},
-
- // The mobile repo requires Go 1.13+.
- {b("android-amd64-emu", "mobile"), both},
- {b("android-amd64-emu", "mobile@1.10"), none},
- {b("android-amd64-emu@go1.10", "mobile"), none},
- {b("android-amd64-emu@go1.13", "mobile"), both},
- {b("android-amd64-emu", "mobile@1.13"), both},
+ {b("linux-386-softfloat@go1.18", "crypto"), onlyPost},
+ {b("linux-386-softfloat@go1.17", "crypto"), onlyPost},
{b("android-amd64-emu", "go"), both},
+ {b("android-amd64-emu", "mobile"), both},
{b("android-amd64-emu", "crypto"), both},
{b("android-amd64-emu", "net"), both},
{b("android-amd64-emu", "sync"), both},
@@ -439,10 +433,6 @@
{b("android-386-emu", "go"), onlyPost},
{b("android-386-emu", "mobile"), onlyPost},
- {b("android-386-emu", "mobile@1.10"), none},
- {b("android-386-emu@go1.10", "mobile"), none},
- {b("android-386-emu@go1.13", "mobile"), onlyPost},
- {b("android-386-emu", "mobile@1.13"), onlyPost},
{b("linux-amd64", "net"), both},
{b("linux-amd64", "net@1.12"), both},
@@ -658,12 +648,12 @@
{b("dragonfly-amd64", "go"), onlyPost},
{b("dragonfly-amd64", "net"), onlyPost},
- {b("dragonfly-amd64@go1.13", "net"), none}, // Dragonfly ABI changes only supported by Go 1.14+
- {b("dragonfly-amd64@go1.13", "go"), none}, // Dragonfly ABI changes only supported by Go 1.14+
+ {b("dragonfly-amd64@go1.18", "net"), onlyPost}, // Dragonfly ABI changes supported by Go 1.14+
+ {b("dragonfly-amd64@go1.18", "go"), onlyPost}, // Dragonfly ABI changes supported by Go 1.14+
{b("linux-amd64-staticlockranking", "go"), onlyPost},
- {b("linux-amd64-staticlockranking@go1.15", "go"), onlyPost},
- {b("linux-amd64-staticlockranking@go1.14", "go"), none},
+ {b("linux-amd64-staticlockranking@go1.18", "go"), onlyPost},
+ {b("linux-amd64-staticlockranking@go1.17", "go"), onlyPost},
{b("linux-amd64-staticlockranking", "net"), none},
{b("linux-amd64-unified", "go"), both},
