app/appengine: delete yet more dead code
This is part of a series of CLs to clean up the build.golang.org App
Engine app in prep for it to be modernized, refactored, and replaced,
starting with deleting dead code.
Some of this was missed in CL 208319.
Updates golang/go#34744
Change-Id: I35adf4296b849dabed9d974e7eb58eeedc7d4293
Reviewed-on: https://go-review.googlesource.com/c/build/+/208397
Reviewed-by: Andrew Gerrand <adg@golang.org>
diff --git a/app/appengine/build.go b/app/appengine/build.go
index 9fd907e..b4a4825 100644
--- a/app/appengine/build.go
+++ b/app/appengine/build.go
@@ -86,12 +86,10 @@
ParentHash string
Num int // Internal monotonic counter unique to this package.
- User string
- Desc string `datastore:",noindex"`
- Time time.Time
- NeedsBenchmarking bool
- TryPatch bool
- Branch string
+ User string
+ Desc string `datastore:",noindex"`
+ Time time.Time
+ Branch string
// ResultData is the Data string of each build Result for this Commit.
// For non-Go commits, only the Results for the current Go tip, weekly,
diff --git a/app/appengine/cron-part.yaml b/app/appengine/cron-part.yaml
deleted file mode 100644
index 6747dda..0000000
--- a/app/appengine/cron-part.yaml
+++ /dev/null
@@ -1,6 +0,0 @@
-# To load, run ./cron.sh
-- description: updates noise level for benchmarking results
- url: /perflearn?update=1
- schedule: every 24 hours
- target: build
-
diff --git a/app/appengine/index.yaml b/app/appengine/index.yaml
index 31f97c4..0aeb518 100644
--- a/app/appengine/index.yaml
+++ b/app/appengine/index.yaml
@@ -18,10 +18,3 @@
properties:
- name: Time
direction: desc
-
-- kind: Commit
- ancestor: yes
- properties:
- - name: NeedsBenchmarking
- - name: Num
- direction: desc
diff --git a/app/appengine/init.go b/app/appengine/init.go
index ffc1dc2..1be69fc 100644
--- a/app/appengine/init.go
+++ b/app/appengine/init.go
@@ -41,19 +41,5 @@
// Create secret key.
key.Secret(c)
- // Populate Go 1.4 tag. This is for bootstrapping the new feature of
- // building sub-repos against the stable release.
- // TODO(adg): remove this after Go 1.5 is released, at which point the
- // build system will pick up on the new release tag automatically.
- t := &Tag{
- Kind: "release",
- Name: "release-branch.go1.4",
- Hash: "883bc6ed0ea815293fe6309d66f967ea60630e87", // Go 1.4.2
- }
- if _, err := datastore.Put(c, t.Key(c), t); err != nil {
- logErr(w, r, err)
- return
- }
-
fmt.Fprint(w, "OK")
}
diff --git a/app/appengine/static/style.css b/app/appengine/static/style.css
index 3c27bf3..34c6603 100644
--- a/app/appengine/static/style.css
+++ b/app/appengine/static/style.css
@@ -269,11 +269,6 @@
padding: 2px 8px;
}
-.diff-benchmark {
- clear: both;
- padding-top: 5px;
-}
-
/* positioning elements */
.page {
diff --git a/app/appengine/ui.go b/app/appengine/ui.go
index 4e6c69a..2b3f769 100644
--- a/app/appengine/ui.go
+++ b/app/appengine/ui.go
@@ -429,10 +429,6 @@
}
func builderPriority(builder string) (p int) {
- // Put -temp builders at the end, always.
- if strings.HasSuffix(builder, "-temp") {
- defer func() { p += 20 }()
- }
// Group race builders together.
if isRace(builder) {
return 2
@@ -450,9 +446,6 @@
}
func unsupported(builder string) bool {
- if strings.HasSuffix(builder, "-temp") {
- return true
- }
return unsupportedOS(builderOS(builder))
}
@@ -688,7 +681,7 @@
for len(s) > 0 {
i := 1
os := builderOSOrRace(s[0])
- u := unsupportedOS(os) || strings.HasSuffix(s[0], "-temp")
+ u := unsupportedOS(os)
for i < len(s) && builderOSOrRace(s[i]) == os {
i++
}
