dashboard: re-enable "review" repo on Dragonfly and AIX builders
This partially reverts CL 192327.
Reason for revert: x/review failure turned out to be a bug in the test.
Updates golang/go#32836
Change-Id: I189ad4ebc1b48fbdbb64f3e42ab1459761ff0c8c
Reviewed-on: https://go-review.googlesource.com/c/build/+/211497
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
diff --git a/dashboard/builders.go b/dashboard/builders.go
index e76019e..1ad19e6 100644
--- a/dashboard/builders.go
+++ b/dashboard/builders.go
@@ -2360,12 +2360,6 @@
shouldRunDistTest: noTestDir,
SkipSnapshot: true,
buildsRepo: func(repo, branch, goBranch string) bool {
- if repo == "review" {
- // '.git/hooks/pre-commit' cannot be executed on this builder,
- // which causes the x/review tests to fail.
- // (https://golang.org/issue/32836)
- return false
- }
return atLeastGo1(goBranch, 14) && defaultBuildsRepoPolicy(repo, branch, goBranch)
},
})
@@ -2454,7 +2448,7 @@
// The x/net package wasn't working in Go 1.12; AIX folk plan to have
// it ready by Go 1.13. See https://golang.org/issue/31564#issuecomment-484786144
return atLeastGo1(branch, 13) && atLeastGo1(goBranch, 13)
- case "review", "tools", "tour", "website":
+ case "tools", "tour", "website":
// The PATH on this builder is misconfigured in a way that causes
// any test that executes a 'go' command as a subprocess to fail.
// (https://golang.org/issue/31567).
