cmd/coordinator: add some more checks & logging to debug Rev-less x/tools tries
Change-Id: I2fef2f01991d2942d6d9fd0bb1f335881148bc45
Reviewed-on: https://go-review.googlesource.com/c/build/+/205605
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
diff --git a/cmd/coordinator/coordinator.go b/cmd/coordinator/coordinator.go
index 894a3ee..408b913 100644
--- a/cmd/coordinator/coordinator.go
+++ b/cmd/coordinator/coordinator.go
@@ -1238,7 +1238,7 @@
}
bs, err := newBuild(brev)
if err != nil {
- log.Printf("can't create build for %q: %v", rev, err)
+ log.Printf("can't create x/%s trybot build for go/master commit %s: %v", project, rev, err)
return nil
}
addBuilderToSet(bs, brev)
@@ -1598,6 +1598,10 @@
if !ok {
return nil, fmt.Errorf("unknown builder type %q", rev.Name)
}
+ if rev.Rev == "" {
+ return nil, fmt.Errorf("required field Rev is empty; got %+v", rev)
+ }
+
ctx, cancel := context.WithCancel(context.Background())
return &buildStatus{
buildID: "B" + randHex(9),
