builders: skip the reboot test in more places, especially on slower builders
It's not important to run the new "reboot" bootstrapping test on all
builders; a few is fine. Skip it on plan9-arm, etc, and on trybots that aren't
super widely sharded.
Change-Id: I35d5408eb5e034f42df5976f2b9b7f7d478d580a
Reviewed-on: https://go-review.googlesource.com/c/build/+/167998
Reviewed-by: David du Colombier <0intro@gmail.com>
diff --git a/dashboard/builders.go b/dashboard/builders.go
index 87e0abc..733ff39 100644
--- a/dashboard/builders.go
+++ b/dashboard/builders.go
@@ -2059,9 +2059,10 @@
},
})
addBuilder(BuildConfig{
- Name: "plan9-arm",
- HostType: "host-plan9-arm-0intro",
- SkipSnapshot: true,
+ Name: "plan9-arm",
+ HostType: "host-plan9-arm-0intro",
+ ShouldRunDistTest: noTestDir,
+ SkipSnapshot: true,
})
addBuilder(BuildConfig{
Name: "nacl-arm",
@@ -2070,9 +2071,10 @@
SkipSnapshot: true,
})
addBuilder(BuildConfig{
- Name: "plan9-amd64-9front",
- HostType: "host-plan9-amd64-0intro",
- SkipSnapshot: true,
+ Name: "plan9-amd64-9front",
+ HostType: "host-plan9-amd64-0intro",
+ ShouldRunDistTest: noTestDir,
+ SkipSnapshot: true,
})
addBuilder(BuildConfig{
Name: "aix-ppc64",
@@ -2120,16 +2122,21 @@
// fasterTrybots is a ShouldRunDistTest policy function.
// It skips (returns false) the test/ directory tests for trybots.
func fasterTrybots(distTest string, isTry bool) bool {
- if isTry && strings.HasPrefix(distTest, "test:") {
- return false // skip test
+ if isTry {
+ if strings.HasPrefix(distTest, "test:") ||
+ distTest == "reboot" {
+ return false // skip test
+ }
}
return true
}
// noTestDir is a ShouldRunDistTest policy function.
-// It skips (returns false) the test/ directory tests for all builds.
+// It skips (returns false) the test/ directory tests for all builds,
+// as well as the "reboot" test that tests that recompiling Go with
+// the just-built Go works.
func noTestDir(distTest string, isTry bool) bool {
- if strings.HasPrefix(distTest, "test:") {
+ if strings.HasPrefix(distTest, "test:") || distTest == "reboot" {
return false // skip test
}
return true
