dashboard: disable failing repos on misconfigured builders
Updates golang/go#32836
Updates golang/go#31567
Updates golang/go#11811
Change-Id: I5443b61cf7732abf906ce2e93eca5408579a55c8
Reviewed-on: https://go-review.googlesource.com/c/build/+/192327
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
diff --git a/dashboard/builders.go b/dashboard/builders.go
index 43246ce..a0a89d0 100644
--- a/dashboard/builders.go
+++ b/dashboard/builders.go
@@ -2050,6 +2050,15 @@
Name: "illumos-amd64-joyent",
HostType: "host-illumos-amd64-joyent",
MinimumGoVersion: types.MajorMinor{1, 13},
+ buildsRepo: func(repo, branch, goBranch string) bool {
+ if repo == "review" {
+ // '.git/hooks/pre-commit' cannot be executed on this builder,
+ // which causes the x/review tests to fail.
+ // (https://golang.org/issue/32836)
+ return false
+ }
+ return defaultBuildsRepoPolicy(repo, branch, goBranch)
+ },
})
addBuilder(BuildConfig{
Name: "linux-ppc64-buildlet",
@@ -2120,6 +2129,15 @@
HostType: "host-dragonfly-amd64-tdfbsd",
shouldRunDistTest: noTestDir,
SkipSnapshot: true,
+ buildsRepo: func(repo, branch, goBranch string) bool {
+ if repo == "review" {
+ // '.git/hooks/pre-commit' cannot be executed on this builder,
+ // which causes the x/review tests to fail.
+ // (https://golang.org/issue/32836)
+ return false
+ }
+ return defaultBuildsRepoPolicy(repo, branch, goBranch)
+ },
})
addBuilder(BuildConfig{
Name: "freebsd-arm-paulzhol",
@@ -2195,6 +2213,12 @@
// The x/net package wasn't working in Go 1.12; AIX folk plan to have
// it ready by Go 1.13. See https://golang.org/issue/31564#issuecomment-484786144
return atLeastGo1(branch, 13) && atLeastGo1(goBranch, 13)
+ case "review", "tools", "tour":
+ // The PATH on this builder is misconfigured in a way that causes tests
+ // in x/review, x/tools and x/tour to fail
+ // (https://golang.org/issue/31567).
+ // Skip those until the builder is fixed.
+ return false
}
return atLeastGo1(branch, 12) && atLeastGo1(goBranch, 12) && defaultBuildsRepoPolicy(repo, branch, goBranch)
},
