app/appengine: move some code, remove some variables
From comment by Alex on at
https://go-review.googlesource.com/c/build/+/210997/5/app/appengine/ui.go#69
Change-Id: I5aa3ee0ee0d0c2f434c8a78ae5127ebb089a60ec
Reviewed-on: https://go-review.googlesource.com/c/build/+/211078
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
diff --git a/app/appengine/ui.go b/app/appengine/ui.go
index e731736..4f8ea00 100644
--- a/app/appengine/ui.go
+++ b/app/appengine/ui.go
@@ -45,19 +45,19 @@
}
ctx := r.Context()
- var (
- dashRes *apipb.DashboardResponse
- activeBuilds []types.ActivePostSubmitBuild
- )
+ tb := &uiTemplateDataBuilder{
+ view: view,
+ req: dashReq,
+ }
var rpcs errgroup.Group
rpcs.Go(func() error {
var err error
- dashRes, err = maintnerClient.GetDashboard(ctx, dashReq)
+ tb.res, err = maintnerClient.GetDashboard(ctx, dashReq)
return err
})
if view.ShowsActiveBuilds() {
rpcs.Go(func() error {
- activeBuilds = getActiveBuilds(ctx)
+ tb.activeBuilds = getActiveBuilds(ctx)
return nil
})
}
@@ -65,13 +65,6 @@
http.Error(w, "maintner.GetDashboard: "+err.Error(), httpStatusOfErr(err))
return
}
-
- tb := &uiTemplateDataBuilder{
- view: view,
- req: dashReq,
- res: dashRes,
- activeBuilds: activeBuilds,
- }
data, err := tb.buildTemplateData(ctx)
if err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError)
