cmd/releasebot, cmd/release: add 2 more longtest test-only targets
Add support for a linux-386-longtest test-only target. This is the
third longtest builder that we have.
Both linux-{386,amd64}-longtest targets are passing on master
for future Go 1.17 releases, as well as release-branch.go1.16
and release-branch.go1.15 now that CL 288818 is cherry-picked
(see backport issues golang/go#45240 and golang/go#45239).
Start including them in the release process by default, so that we
have more automated test coverage and more information available
during the upcoming releases, and in turn can use it to improve
the releases and the release process further.
Fixes golang/go#29252.
Change-Id: I9740c9ce5cae73a3ed9fe320219f1044f5fdcc9a
Reviewed-on: https://go-review.googlesource.com/c/build/+/304949
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
diff --git a/cmd/release/release.go b/cmd/release/release.go
index bf28b68..5f5a609 100644
--- a/cmd/release/release.go
+++ b/cmd/release/release.go
@@ -263,6 +263,11 @@
// Test-only builds.
{
+ Builder: "linux-386-longtest",
+ OS: "linux", Arch: "386",
+ TestOnly: true,
+ },
+ {
Builder: "linux-amd64-longtest",
OS: "linux", Arch: "amd64",
TestOnly: true,
diff --git a/cmd/releasebot/main.go b/cmd/releasebot/main.go
index 49b6e9f..bb70716 100644
--- a/cmd/releasebot/main.go
+++ b/cmd/releasebot/main.go
@@ -59,6 +59,7 @@
{Name: "linux-ppc64le"},
// Test-only targets.
+ {Name: "linux-386-longtest", TestOnly: true},
{Name: "linux-amd64-longtest", TestOnly: true},
{Name: "windows-amd64-longtest", TestOnly: true},
}
@@ -75,7 +76,7 @@
}
var (
- skipTestFlag = flag.String("skip-test", "linux-amd64-longtest", "space-separated list of test-only targets to skip (only use if sufficient testing was done elsewhere)")
+ skipTestFlag = flag.String("skip-test", "", "space-separated list of test-only targets to skip (only use if sufficient testing was done elsewhere)")
)
var (
diff --git a/cmd/releasebot/main_test.go b/cmd/releasebot/main_test.go
index 5c83bdd..7aaefc0 100644
--- a/cmd/releasebot/main_test.go
+++ b/cmd/releasebot/main_test.go
@@ -23,7 +23,10 @@
want []string // Expected release targets.
}{
{
- goVer: []string{"go1.16beta1", "go1.16rc1", "go1.16", "go1.16.1"},
+ goVer: []string{
+ "go1.17beta1", "go1.17rc1", "go1.17", "go1.17.1",
+ "go1.16.3",
+ },
want: []string{
"src",
"linux-386",
@@ -38,12 +41,13 @@
"darwin-arm64", // New to Go 1.16.
"linux-s390x",
"linux-ppc64le",
+ "linux-386-longtest",
"linux-amd64-longtest",
"windows-amd64-longtest",
},
},
{
- goVer: []string{"go1.15.7", "go1.14.14"},
+ goVer: []string{"go1.15.11"},
want: []string{
"src",
"linux-386",
@@ -57,6 +61,7 @@
"darwin-amd64",
"linux-s390x",
"linux-ppc64le",
+ "linux-386-longtest",
"linux-amd64-longtest",
"windows-amd64-longtest",
},
