sweet: disable gVisor by default gVisor is broken as of https://go.dev/cl/652276. For golang/go#72042. Fixes golang/go#68437. Change-Id: I6a6a636caa3a65c3c58d30ed26d877dba9378afe Reviewed-on: https://go-review.googlesource.com/c/benchmarks/+/653755 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> Auto-Submit: Michael Pratt <mpratt@google.com>
diff --git a/sweet/cmd/sweet/benchmark.go b/sweet/cmd/sweet/benchmark.go index 30006a7..155cb32 100644 --- a/sweet/cmd/sweet/benchmark.go +++ b/sweet/cmd/sweet/benchmark.go
@@ -111,9 +111,12 @@ allBenchmarksMap["go-build"], allBenchmarksMap["gopher-lua"], } - if runtime.GOARCH == "amd64" { - m["default"] = append(m["default"], allBenchmarksMap["gvisor"]) - } + // TODO(go.dev/issue/72042): gVisor is broken at Go tip as of + // https://go.dev/cl/652276 due to unsafe dependence on field offsets. + // Disable until gVisor upstream is fixed. + // if runtime.GOARCH == "amd64" { + // m["default"] = append(m["default"], allBenchmarksMap["gvisor"]) + // } m["default"] = append(m["default"], allBenchmarksMap["markdown"], allBenchmarksMap["tile38"],
diff --git a/sweet/cmd/sweet/integration_test.go b/sweet/cmd/sweet/integration_test.go index 0722f79..1571104 100644 --- a/sweet/cmd/sweet/integration_test.go +++ b/sweet/cmd/sweet/integration_test.go
@@ -213,7 +213,8 @@ {"bleve-index", 1}, {"gopher-lua", 1}, {"markdown", 1}, - {"gvisor", 1}, + // TODO(go.dev/issue/72042): re-enable once fixed upstream. + // {"gvisor", 1}, } { sema.Acquire(context.Background(), shard.weight) wg.Add(1)