project.config: remove Code-Review-2 in favor of Hold+1
diff --git a/project.config b/project.config index b4b7316..10c3130 100644 --- a/project.config +++ b/project.config
@@ -23,8 +23,9 @@ forgeAuthor = group may-push forgeCommitter = group gerritbot forgeCommitter = group may-push - label-Code-Review = -2..+2 group approvers - label-Code-Review = -1..+1 group Registered Users + label-Code-Review = 0..+2 group approvers + label-Code-Review = 0..+1 group Registered Users + label-Hold = +0..+1 group approvers submit = group approvers submit = group gobot editTopicName = group approvers @@ -44,7 +45,7 @@ read = group mdb/golang-gob-owners read = group mdb/gerritcodereview-eng push = group mdb/golang-gob-owners - label-Code-Review = -2..+2 group mdb/golang-gob-owners + label-Code-Review = 0..+2 group mdb/golang-gob-owners submit = group mdb/golang-gob-owners [access "refs/tags/*"] push = group may-push @@ -138,6 +139,10 @@ applicableIf = message:\"^.*(D|d)(O|o) (N|n)(O|o)(T|t) (R|r)(E|e)(V|v)(I|i)(E|e)(W|w).*\" submittableIf = is:false [submit-requirement "Code-Review"] - description = At least one maximum vote for label 'Code-Review' is required. Self review is not allowed. - submittableIf = label:Code-Review=MAX,user=non_uploader AND -label:Code-Review=MIN + description = At least one Code-Review+2 is required. Self review is not allowed. + submittableIf = label:Code-Review=MAX,user=non_uploader canOverrideInChildProjects = true +[submit-requirement "Hold"] + description = Changes with a Hold+1 vote are not submittable. + applicableIf = label:Hold=1 + submittableIf = is:false