| commit | 9702cd980fadefe4d6740a52d32fb1ad52e984cc | [log] [tgz] |
|---|---|---|
| author | Cherry Mui <cherryyz@google.com> | Mon Apr 22 15:58:29 2024 -0400 |
| committer | Cherry Mui <cherryyz@google.com> | Tue Apr 23 01:21:39 2024 +0000 |
| tree | d7240bc3dfebf867f85b4387b718d5bfeb88dc13 | |
| parent | 0c39dc1ff72181d36f7e9fc61bfacc5a7b7c5c57 [diff] |
cmd/compile: mark closure DUPOK if the outer function is If a function is DUPOK (e.g. an instantiation of a generic function) and contains closures, the closure also needs to be DUPOK. Otherwise, when the outer function is included in multiple packages, the closure will also be included in these packages, and the linker will dedup the outer function but not the closure, causing duplicated symbols. In normal builds it is mostly still ok as these closure symbols are only referenced by indices. But in shared build mode all symbols are named and kept live, causing an error. Should fix the shared build mode. Change-Id: I227d26e589465440335a4ec7e33d29739ed44aad Reviewed-on: https://go-review.googlesource.com/c/go/+/580917 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Than McIntosh <thanm@google.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.