| commit | 2e064cf14441460290fd25d9d61f02a9d0bae671 | [log] [tgz] |
|---|---|---|
| author | Daniel Martà <mvdan@mvdan.cc> | Thu Apr 04 13:05:13 2024 +0900 |
| committer | Daniel Martà <mvdan@mvdan.cc> | Fri Apr 05 01:26:13 2024 +0000 |
| tree | 8f6794df88befa875af42cff631443eed3121ede | |
| parent | fd999fda5941f215ef082c6ef70e44e648db5485 [diff] |
encoding/csv: port the go-fuzz function to native fuzzing Beyond the required file move and refactor to use the testing package, a number of changes were made to get the fuzzing working properly. First, add more logs to see what is going on. Second, some option combinations set Comma to the null character, which simply never worked at all. I suspect the author meant to leave the comma character as the default instead. This was spotted thanks to the added logging. Third, the round-trip DeepEqual check did not work at all when any comments were involved, as the writer does not support them. Fourth and last, massage the first and second parsed records before comparing them with DeepEqual, as the nature of Reader and Writer causes empty quoted records and CRLF sequences to change. With all the changes above, the fuzzing function appears to work normally on my laptop now. I fuzzed for a solid five minutes and could no longer encounter any errors or panics. Change-Id: Ie27f65f66099bdaa076343cee18b480803d2e4d3 Reviewed-on: https://go-review.googlesource.com/c/go/+/576375 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Joseph Tsai <joetsai@digital-static.net> Reviewed-by: Ian Lance Taylor <iant@google.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.