Google Git
Sign in
go / pkgsite / fa961d12411ccab87f4868c2933611003e0d8ffd
commitfa961d12411ccab87f4868c2933611003e0d8ffd[log] [tgz]
authorJonathan Amsterdam <jba@google.com>Wed Feb 14 09:23:32 2024 -0500
committerJonathan Amsterdam <jba@google.com>Wed Feb 14 17:07:49 2024 +0000
tree1aa3d28f1094185b201cda8bb1ef2ea428136a16
parent92ac56ef5902d8f41d8fd845fde46d3383c24ba4 [diff]
internal/fetch: handle error in root package

If a module had a problem with the package at its root, we would
end up with two packageVersionStates. That caused a DB error
in upsertPackageVersionStates.

Distinguish between the module unit and package units in a couple
of places. That addresses the root cause of the problem.

Also, fix an unrelated bug that was causing a panic when we
tried to send the error to the errorreporting service.

Change-Id: Ia02faea50f4477999c6c6eca0674b8dde0f15bb3
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/564076
Reviewed-by: Michael Matloob <matloob@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
5 files changed
tree: 1aa3d28f1094185b201cda8bb1ef2ea428136a16
  1. .github/
  2. cmd/
  3. deploy/
  4. devtools/
  5. doc/
  6. internal/
  7. migrations/
  8. static/
  9. tests/
  10. third_party/
  11. .dockerignore
  12. .eslintignore
  13. .eslintrc.yaml
  14. .gitignore
  15. .prettierignore
  16. .prettierrc.yaml
  17. .stylelintignore
  18. .stylelintrc.yaml
  19. all.bash
  20. CONTRIBUTING.md
  21. go.mod
  22. go.sum
  23. jest.config.js
  24. LICENSE
  25. package-lock.json
  26. package.json
  27. PATENTS
  28. README.md
  29. tsconfig.json
README.md

golang.org/x/pkgsite

This repository hosts the source code of the pkg.go.dev website, and pkgsite, a documentation server program.

Go Reference

pkg.go.dev: a site for discovering Go packages

Pkg.go.dev is a website for discovering and evaluating Go packages and modules.

You can check it out at https://pkg.go.dev.

pkgsite: a documentation server

pkgsite program extracts and generates documentation for Go projects.

Example usage:

$ go install golang.org/x/pkgsite/cmd/pkgsite@latest
$ cd myproject
$ pkgsite -open .

For more information, see the pkgsite documentation.

Requirements

Pkgsite requires Go 1.19 to run. The last commit that works with Go 1.18 is 9ffe8b928e4fbd3ff7dcf984254629a47f8b6e63. The last commit that works with Go 1.17 is 4d836c6a652cde92f433967680dfd6171a91ec12.

Issues

If you want to report a bug or have a feature suggestion, please first check the known issues to see if your issue is already being discussed. If an issue does not already exist, feel free to file an issue.

For answers to frequently asked questions, see pkg.go.dev/about.

You can also chat with us on the #pkgsite Slack channel on the Gophers Slack.

Contributing

We would love your help!

Our canonical Git repository is located at go.googlesource.com/pkgsite. There is a mirror of the repository at github.com/golang/pkgsite.

To contribute, please read our contributing guide.

License

Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.

Links