| commit | c686783cabd4603cdff662f8cf9180c4f76b7928 | [log] [tgz] |
|---|---|---|
| author | Than McIntosh <thanm@google.com> | Thu Apr 11 15:16:22 2024 +0000 |
| committer | Than McIntosh <thanm@google.com> | Wed Apr 17 19:39:19 2024 +0000 |
| tree | e28bdef22fad7210f851410c122678a1beed9a90 | |
| parent | 076166ab4e13506c90448b5d6e0f34c3939ee76f [diff] |
cmd/compile/internal/ssa: delay rewrite cycle detection for huge funcs The SSA rewrite pass has some logic that looks to see whether a suspiciously large number of rewrites is happening, and if so, turns on logic to try to detect rewrite cycles. The cycle detection logic is quite expensive (hashes the entire function), meaning that for very large functions we might get a successful compilation in a minute or two with no cycle detection, but take a couple of hours once cycle detection kicks in. This patch moves from a fixed limit of 1000 iterations to a limit set partially based on the size of the function (meaning that we'll wait longer before turning cycle detection for a large func). Fixes #66773. Change-Id: I72f8524d706f15b3f0150baf6abeab2a5d3e15c4 Reviewed-on: https://go-review.googlesource.com/c/go/+/578215 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Cherry Mui <cherryyz@google.com>
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.