Google Git
Sign in
go / wiki / a89d1ce523c2696020795d966d31c78fecbc99be / CodeReviewComments.md
  1. ce934ad "ID" is short for "identifier", not "Identity Document", in the example "appID". by Pindi Albert · 6 years ago
  2. b191929 Remove misleading issue body from new issue link, include Documentation label. by Dmitri Shuralyov · 6 years ago
  3. 962830b "named returns" -> "naked returns" by Jason Alan Palmer · 6 years ago
  4. 1f9a179 Updated CodeReviewComments (markdown) by Michael Matloob · 6 years ago
  5. 08263eb receiver names: clarified why the receiver name should not use me, this, or self. by Agniva De Sarker · 6 years ago
  6. 16b0973 Clarify the "ID" vs "id" argument by Alex Zlotnik · 6 years ago
  7. 1c58cd1 Specify where changes should be discussed. See golang.org/issue/27913. by Dmitri Shuralyov · 7 years ago
  8. f22d526 Revert a change that was added without proper discussion. We can consider re-adding it after further discussion. by Dmitri Shuralyov · 7 years ago
  9. 88a45ae I love this document and want to make it perfect. by radbaron · 7 years ago
  10. 5a40ba3 Added "comprehensive" in "not a style guide" by Ian Lance Taylor · 7 years ago
  11. f9af9d4 fix typo by Kenshi Kamata · 7 years ago
  12. baec72a I think this place is wrong. by luantao · 7 years ago
  13. dbdd5b0 Grammar fix. by Victor van Poppelen · 7 years ago
  14. 2456bc2 Updated CodeReviewComments (markdown) by Tomoya Ishizaki · 7 years ago
  15. e4063d7 improved previous change, better english by vkuzmin-uber · 7 years ago
  16. 7e850bd I recently attempted to formalize this rule and implemented as golint feature https://github.com/golang/lint/issues/374. It was rejected and closed. I have decided at least mention here that this rule is not so obvious. by vkuzmin-uber · 7 years ago
  17. 4cc16f3 Fix a typo by lylex · 7 years ago
  18. 1f9a384 Removed vestiges of code.google.com as requested by @dgryski in https://github.com/golang/go/issues/23678 by Emmanuel T Odeke · 7 years ago
  19. 155654e Updated CodeReviewComments (markdown) by Brad Fitzpatrick · 7 years ago
  20. 4434a5a Remove extra word from "Indent Error Flow" example by Lachlan Cooper · 7 years ago
  21. 8898bf2 Add formatting to render code like code. by Hoon H · 8 years ago
  22. 3c4eb23 Updated CodeReviewComments (markdown) by Brad Fitzpatrick · 8 years ago
  23. d2c439a Updated CodeReviewComments (markdown) by Brad Fitzpatrick · 8 years ago
  24. 4d5a1b0 Updated CodeReviewComments (markdown) by Andrew Gerrand · 8 years ago
  25. c9f7de7 Fix crypt-rand link by Kenny Grant · 8 years ago
  26. 5a81ed6 Updated CodeReviewComments (markdown) by Jaana B. Dogan · 8 years ago
  27. 220c534 Add Synchronous Functions. by Jaana B. Dogan · 8 years ago
  28. 7ca7f1f Update Receiver Type. by Jaana B. Dogan · 8 years ago
  29. 1755928 Updated CodeReviewComments (markdown) by Jaana B. Dogan · 8 years ago
  30. 1583ba3 Capitalize gofmt. by Jaana B. Dogan · 8 years ago
  31. 0df7fa5 Update Named Result Parameters. by Jaana B. Dogan · 8 years ago
  32. 4ac42e3 Updated CodeReviewComments (markdown) by Jaana B. Dogan · 8 years ago
  33. 8656afc Revise "Package Comments". by Jaana B. Dogan · 8 years ago
  34. 2840754 Updated CodeReviewComments (markdown) by Jaana B. Dogan · 8 years ago
  35. 88f0e01 Add Intefaces. by Jaana B. Dogan · 8 years ago
  36. ad8c445 Add In-Band Errors. by Jaana B. Dogan · 8 years ago
  37. 860d784 Revise Imports. by Jaana B. Dogan · 8 years ago
  38. f11f8f7 Updated CodeReviewComments (markdown) by Jaana B. Dogan · 8 years ago
  39. 8590e71 Add Goroutine Lifetimes. by Jaana B. Dogan · 8 years ago
  40. b181e78 Add Examples. by Jaana B. Dogan · 8 years ago
  41. 9b33933 Add CryptoRand. by Jaana B. Dogan · 8 years ago
  42. dcc731c Add copying. by Jaana B. Dogan · 8 years ago
  43. b824d41 Add contexts. by Jaana B. Dogan · 8 years ago
  44. 6a3e308 log.Print should be log.Printf("Reading %s: %v", filename, err) because format specifiers and arguments are used by Steve Carrupt · 8 years ago
  45. 6db1649 Code comments for structs or functions should always start with the name of the thing they are documenting. by Martin Bertschler · 8 years ago
  46. 0e2fe19 Missing word fix by Terry Liu · 8 years ago
  47. 771f1c7 slightly better english grammer and makes it easier to understand which is the prefered method by Toby Allen · 8 years ago
  48. 2c403c2 Update http links to https. It's 2016, no reason not to since golang.org supports it. by Dmitri Shuralyov · 9 years ago
  49. 4cb9dac Fixed typo by Christopher Dunn · 9 years ago
  50. 68ab16c "Some rules of thumb" -> "Some useful guidelines". Whether historically accurate or not, "rule of thumb" is frequently perceived to have abusive origins. by Kevin Gillette · 9 years ago
  51. e6f8213 Revert bad edit by Andrew Gerrand · 9 years ago
  52. 2c6abb8 Revert ba29054a63aac679bbfe042387909b5bc94c037e...05b95d71ee086df99c922817e1fa318e73cd7135 on CodeReviewComments by Andrew Gerrand · 9 years ago
  53. 05b95d7 Updated CodeReviewComments (markdown) by Steve Streeting · 10 years ago
  54. ba29054 Updated CodeReviewComments (markdown) by Steve Streeting · 10 years ago
  55. e3ee7b0 Updated CodeReviewComments (markdown) by Earl J. Wagner · 10 years ago
  56. 2ae2832 Updated CodeReviewComments (markdown) by Earl J. Wagner · 10 years ago
  57. 7dda73c Adds "Declaring Empty Slices". by Earl J. Wagner · 10 years ago
  58. 812cb13 CodeReviewComments: update link from Naked Returns. by nathany · 10 years ago
  59. 4d6a1bf CodeReviewComments: urls for goimports, table driven tests. TOC. Go syntax highlighting. by nathany · 10 years ago
  60. 0d6986a Fix formatting after import by Dave Day · 10 years ago
  61. 5bc444d Wiki data import from Google Code by Andrew Gerrand · 10 years ago