commit df01d8eb50ad98785bcc6a7837a967f418a2673e
author Andrew Bonventre <andybons@golang.org> Fri Jul 26 13:56:53 2019 -0700
committer Andrew Bonventre <andybons@golang.org> Sat Jul 27 17:10:05 2019 +0000
tree 25d7153e8d456502e20fff6aa60c124cf83ed839
parent 7fe03817672258bf9194caf72339c61e0f6722c3

cmd/golangorg: remove call to flag.Parse in regtest init func

flag.Parse during init is always incorrect (other packages may
want to register flags).

Updates golang/go#31859

Change-Id: Id65bfaab52075220897aacb78c4a7bb6dba16c58
Reviewed-on: https://go-review.googlesource.com/c/website/+/187738
Reviewed-by: Agniva De Sarker <agniva.quicksilver@gmail.com>

cmd/golangorg/regtest_test.go

diff --git a/cmd/golangorg/regtest_test.go b/cmd/golangorg/regtest_test.go
index f7c7219..bedb77b 100644
--- a/cmd/golangorg/regtest_test.go
+++ b/cmd/golangorg/regtest_test.go
@@ -20,12 +20,8 @@
 
 var host = flag.String("regtest.host", "", "host to run regression test against")
 
-func init() {
-	flag.Parse()
-	*host = strings.TrimSuffix(*host, "/")
-}
-
 func TestLiveServer(t *testing.T) {
+	*host = strings.TrimSuffix(*host, "/")
 	if *host == "" {
 		t.Skip("regtest.host flag missing.")
 	}