Google Git
Sign in
go / website / c860785947bfe91e9800e78e1c3ea527cbeba916
commitc860785947bfe91e9800e78e1c3ea527cbeba916[log] [tgz]
authorMauri de Souza Meneguzzo <mauri870@gmail.com>Wed Jul 26 20:03:44 2023 +0000
committerJamal Carvalho <jamal@golang.org>Wed Jul 26 20:21:15 2023 +0000
tree9cb89d5ffc1abb100e71921bdb0474a4e2ddbd35
parent5c08bf3ee65177ad7160bd55d4a04bc613d6af9b [diff]
_content: fix error preventing some features to load in dl page

There was an error when setting up the callback for page load in the /dl page, preventing some features to load properly. The error was due to some methods being invoked for the playground textarea field, that for this specific page is not in the dom.

Updated the logic for page load to wait for dom content loaded or check document.readyState since the page might be loaded already when we try to set up the callback.

Fixes: golang/go#61587

Change-Id: I82508a2661167af19b1b4375c66b46ae50c08617
GitHub-Last-Rev: 8415de173b1edab071a65742e7193877d704ed89
GitHub-Pull-Request: golang/website#234
Reviewed-on: https://go-review.googlesource.com/c/website/+/513315
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
1 file changed
tree: 9cb89d5ffc1abb100e71921bdb0474a4e2ddbd35
  1. _content/
  2. _later/
  3. cmd/
  4. internal/
  5. tour/
  6. .eslintrc.yaml
  7. .gitattributes
  8. .prettierrc.yaml
  9. .stylelintrc.yaml
  10. codereview.cfg
  11. content.go
  12. CONTRIBUTING.md
  13. go-app-deploy.sh
  14. go.mod
  15. go.sum
  16. jest-transform.cjs
  17. LICENSE
  18. npm
  19. npx
  20. package-lock.json
  21. package.json
  22. PATENTS
  23. README.md
  24. tsconfig.json
README.md

Go website

Go Reference

This repo holds content and serving programs for the go.dev and golang.org web sites.

Content is in _content/ (go.dev) and tour/ (go.dev/tour). Server code is in cmd/ and internal/.

To run the combined go.dev+golang.org server to preview local content changes, use:

go run ./cmd/golangorg

The supporting programs cmd/admingolangorg and cmd/googlegolangorg are the servers for admin.golang.org and google.golang.org. (They do not use the _content/ directories.)

Each command directory has its own README.md explaining deployment.

JS/TS/CSS Formatting

This repository uses eslint to format JS and TS files, and stylelint to format CSS files.

See also:

It is encouraged that all JS, TS, and CSS code be run through formatters before submitting a change. However, it is not a strict requirement enforced by CI.

Installing npm Dependencies:

  1. Install docker
  2. Create a .gitignore file at repo root
  3. Add .gitignore and node_modules to .gitignore
  4. Run ./npm install

Run ESlint

./npx eslint [options] [file] [dir]

Run Stylelint

./npx stylelint [input] [options]

TypeScript Support

TypeScript files served from _content are transformed into JavaScript. Reference .ts files in html templates as module code.

<script type="module" src="/ts/filename.ts">

Write unit tests for TypeScript code using the jest testing framework.

Run Jest

./npx jest [TestPathPattern]

Deploying

Each time a CL is reviewed and submitted, the code is deployed to App Engine. See cmd/golangorg/README.md for details.

Report Issues / Send Patches

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://go.dev/doc/contribute.

The main issue tracker for the website repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/website:” in the subject line, so it is easy to find.