| commit | 7ba5bfc931930f96a2ef52368fdede63ceea8a90 | [log] [tgz] |
|---|---|---|
| author | Russ Cox <rsc@golang.org> | Thu Nov 04 16:32:59 2021 -0400 |
| committer | Russ Cox <rsc@golang.org> | Tue Nov 09 16:26:20 2021 +0000 |
| tree | 2cc5365489082262b3215472a1d0d79a0561bcc2 | |
| parent | 15a5891cb43e23d8c3c7921a92c10567be1b82f6 [diff] |
go.dev/_content/css: various cleanups 1. Remove all letter-spacing overrides Overriding the letter-spacing might have made sense when we were hard-coding the font (I have my doubts), but it certainly does not make sense now that we are defaulting to the system font instead of a hard-coded font. The effect of the letter-spacing now is to override the font's kerning tables (as if we could do better!) and gives the site a bit of an alien look. The only time a letter-spacing override really works is in ALL CAPS headlines, but we don't have any. 2. Remove font-weight override for article headings The “large but not bold” headings are another thing that don't really work consistently in the variety of fonts users might see. Go back to headings being bold by removing the overrides. Also rewrite a few font-weight: 400 to font-weight: normal for consistency. 3. Change body text to darker grey Using 3e4042 for body text is too light and hurts readability. pkg.go.dev uses 202224 for body text; use that here too. Global search and replace to keep the same number of colors in our palette. 4. Regularize page max-width, line-height Solutions articles were allowed to be 75.75rem wide, but regular articles were capped at 45rem, which is far too narrow when you're using a large screen. Let all articles expand to 75.75rem. (Not sure what is magic about 75.75 but it's used elsewhere too.) Regular line-height to a default of 1.4 for the whole page. Rutter's book _Web Typography_ says 1.4 is a good default for a variety of fonts. The blog was already overriding to 1.4 because that was most readable for the long articles. Many other elements were using 1.5rem, which can then be deleted. Article lists were set to 1.45, so delete that too in favor of consistency. Article text was set to 1.75rem, which is far too wide and hurts readability (the blog was overriding this specific setting), so drop that too. 5. Narrow spaces in code font This rule will let us stop insisting that people write things like Use <code>go</code> <code>get</code> to ... (See for example doc/go1.*.html.) Change-Id: I2154b03296ae1d56bc9bc416a1e3fb9e930d7d9c Reviewed-on: https://go-review.googlesource.com/c/website/+/362015 Trust: Russ Cox <rsc@golang.org> Reviewed-by: Jamal Carvalho <jamal@golang.org> Website-Publish: Russ Cox <rsc@golang.org>
This repo holds content and serving programs for the golang.org and go.dev web sites.
Content is in _content/ (golang.org), go.dev/_content/ (go.dev), and tour/ (tour.golang.org). Server code is in cmd/ and internal/.
To run the combined golang.org+go.dev server to preview local content changes, use:
go run ./cmd/golangorg
The supporting programs cmd/admingolangorg and cmd/googlegolangorg are the servers for admin.golang.org and google.golang.org. (They do not use the _content/ directories.)
Each command directory has its own README.md explaining deployment.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the website repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/website:” in the subject line, so it is easy to find.