cmd/screentest: avoid racing on screenshot errors testcase.run starts concurrent goroutines to capture the test and want screenshots, but both goroutines previously assigned to the same named return variable err. This caused a data race and could result in an incorrect error being returned. Keep the screenshot and error variables local to each goroutine, and assign the outer screenshot variables only after a successful capture. Add regression tests covering failures from either screenshot and failures from both screenshots. Fixes golang/go#80763 Change-Id: Id216f1e8ac2ecc91e9091817d9fca6c3ecc26ee0 Reviewed-on: https://go-review.googlesource.com/c/website/+/811480 Auto-Submit: Ethan Lee <ethanalee@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> Reviewed-by: Ethan Lee <ethanalee@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This repo holds content and serving programs for the go.dev and golang.org web sites.
Content is in _content/ (go.dev) and tour/ (go.dev/tour). Server code is in cmd/ and internal/.
To run the combined go.dev+golang.org server to preview local content changes, use:
go run ./cmd/golangorg
The supporting programs cmd/admingolangorg and cmd/googlegolangorg are the servers for admin.golang.org and google.golang.org. (They do not use the _content/ directories.)
Each command directory has its own README.md explaining deployment.
This repository uses eslint to format JS and TS files, and stylelint to format CSS files.
See also:
It is encouraged that all JS, TS, and CSS code be run through formatters before submitting a change. However, it is not a strict requirement enforced by CI.
./npm install./npx eslint [options] [file] [dir]
./npx stylelint [input] [options]
TypeScript files served from _content are transformed into JavaScript. Reference .ts files in html templates as module code.
<script type="module" src="/ts/filename.ts">
Write unit tests for TypeScript code using the jest testing framework.
./npx jest [TestPathPattern]
Each time a CL is reviewed and submitted, the code is deployed to App Engine. See cmd/golangorg/README.md for details.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://go.dev/doc/contribute.
The git repository is https://go.googlesource.com/website.
The main issue tracker for the website repository is located at https://go.dev/issues. Prefix your issue with “x/website:” in the subject line, so it is easy to find.