Google Git
Sign in
go / website / 1d3e58623b596aee28f04aacc460d1c1bfea54ed
commit1d3e58623b596aee28f04aacc460d1c1bfea54ed[log] [tgz]
authorblackfalcon <blackfalcon.ru@gmail.com>Mon Feb 06 00:28:36 2023 +0000
committerSuzy Mueller <suzmue@golang.org>Tue Feb 07 22:09:57 2023 +0000
tree44e863ed9736ec5c417f7884608a9215e1b02adc
parentc0d7b93e007265f858b8727bdf73967694570659 [diff]
_content/doc: fix parseVersionNumber to handle versions without patch

As of go1.20, when visiting https://go.dev/doc/install, the download button shows no version and with text: `Download ()`.

Previously the function expected the argument `string` being passed as in the form: `go1.17.3.linux-amd64.tar.gz`.
with go1.20 the file name becomes `go1.20.linux-amd64.tar.gz` with no patch number.

This merge request fix the regex used to parse the version number and return the intended version of `1.20`

Change-Id: I2fd109a030ed940cd8cd4d5e8924f026f5b8f4be
GitHub-Last-Rev: 68fb7856ee160ac7221625c96a6d4819cbcb59e4
GitHub-Pull-Request: golang/website#192
Reviewed-on: https://go-review.googlesource.com/c/website/+/465415
Run-TryBot: Suzy Mueller <suzmue@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
1 file changed
tree: 44e863ed9736ec5c417f7884608a9215e1b02adc
  1. _content/
  2. _later/
  3. cmd/
  4. internal/
  5. tour/
  6. .eslintrc.yaml
  7. .gitattributes
  8. .prettierrc.yaml
  9. .stylelintrc.yaml
  10. codereview.cfg
  11. content.go
  12. CONTRIBUTING.md
  13. go-app-deploy.sh
  14. go.mod
  15. go.sum
  16. jest-transform.cjs
  17. LICENSE
  18. npm
  19. npx
  20. package-lock.json
  21. package.json
  22. PATENTS
  23. README.md
  24. tsconfig.json
README.md

Go website

Go Reference

This repo holds content and serving programs for the go.dev and golang.org web sites.

Content is in _content/ (go.dev) and tour/ (go.dev/tour). Server code is in cmd/ and internal/.

To run the combined go.dev+golang.org server to preview local content changes, use:

go run ./cmd/golangorg

The supporting programs cmd/admingolangorg and cmd/googlegolangorg are the servers for admin.golang.org and google.golang.org. (They do not use the _content/ directories.)

Each command directory has its own README.md explaining deployment.

JS/TS/CSS Formatting

This repository uses eslint to format JS and TS files, and stylelint to format CSS files.

See also:

It is encouraged that all JS, TS, and CSS code be run through formatters before submitting a change. However, it is not a strict requirement enforced by CI.

Installing npm Dependencies:

  1. Install docker
  2. Create a .gitignore file at repo root
  3. Add .gitignore and node_modules to .gitignore
  4. Run ./npm install

Run ESlint

./npx eslint [options] [file] [dir]

Run Stylelint

./npx stylelint [input] [options]

TypeScript Support

TypeScript files served from _content are transformed into JavaScript. Reference .ts files in html templates as module code.

<script type="module" src="/ts/filename.ts">

Write unit tests for TypeScript code using the jest testing framework.

Run Jest

./npx jest [TestPathPattern]

Deploying

Each time a CL is reviewed and submitted, the code is deployed to App Engine. See cmd/golangorg/README.md for details.

Report Issues / Send Patches

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://go.dev/doc/contribute.

The main issue tracker for the website repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/website:” in the subject line, so it is easy to find.