commit fe8bfac74aebff26c9e749c21accf902d2606730
author Oleksandr Redko <oleksandr.red+github@gmail.com> Thu Jan 09 23:12:51 2025 +0200
committer Hyang-Ah Hana Kim <hyangah@gmail.com> Wed Jan 15 10:28:22 2025 -0800
tree d6272f269e4dd85e149fdbb571656e056d046777
parent 3fec53289cdfa4264d130399ba261bdfa244d680

package.json: deprecate goformat

goformat can't format modern Go code that uses generics.
See https://github.com/mbenkmann/goformat/issues/2

Change-Id: I6ef36db10677fd7e31ea20bb95d75db5d152edd1
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/641875
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>

docs/settings.md

diff --git a/docs/settings.md b/docs/settings.md
index 65eaa19..6b54646 100644
--- a/docs/settings.md
+++ b/docs/settings.md
@@ -242,7 +242,7 @@
 * `default`: If the language server is enabled, format via the language server, which already supports gofmt, goimports, goreturns, and gofumpt. Otherwise, goimports.
 * `gofmt`: Formats the file according to the standard Go style. (not applicable when the language server is enabled)
 * `goimports`: Organizes imports and formats the file with gofmt. (not applicable when the language server is enabled)
-* `goformat`: Configurable gofmt, see https://github.com/mbenkmann/goformat.
+* `goformat`: Configurable gofmt, see https://github.com/mbenkmann/goformat. (Deprecated due to the lack of generics support)
 * `gofumpt`: Stricter version of gofmt, see https://github.com/mvdan/gofumpt. . Use `#gopls.format.gofumpt#` instead)
 * `custom`: Formats using the custom tool specified as `customFormatter` in the `#go.alternateTools#` setting. The tool should take the input as STDIN and output the formatted code as STDOUT.
 

extension/package.json

diff --git a/extension/package.json b/extension/package.json
index 7ce4b2f..2a63b81 100644
--- a/extension/package.json
+++ b/extension/package.json
@@ -1228,7 +1228,7 @@
             "If the language server is enabled, format via the language server, which already supports gofmt, goimports, goreturns, and gofumpt. Otherwise, goimports.",
             "Formats the file according to the standard Go style. (not applicable when the language server is enabled)",
             "Organizes imports and formats the file with gofmt. (not applicable when the language server is enabled)",
-            "Configurable gofmt, see https://github.com/mbenkmann/goformat.",
+            "Configurable gofmt, see https://github.com/mbenkmann/goformat. (Deprecated due to the lack of generics support)",
             "Stricter version of gofmt, see https://github.com/mvdan/gofumpt. . Use `#gopls.format.gofumpt#` instead)",
             "Formats using the custom tool specified as `customFormatter` in the `#go.alternateTools#` setting. The tool should take the input as STDIN and output the formatted code as STDOUT."
           ]