tree 14a796e05a060a9dfc26562e427cdeb45d709eec
parent a64f4f0ab48c3fb74f7a4b7ad07f84e8cb9bbc4a
author Hana <hyangah@gmail.com> 1608314477 -0500
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1615271188 +0000

src/goLint: switch the default lint tool to staticcheck

Golint is unmaintained and effectively deprecated.
So, switch to staticcheck, which is one of the existing linter
options we've provided, and is actively maintained.

Compared to golint, we observed staticcheck provides more useful
signals about the code style and common errors, while it is still
easy to use.  Some controversial checks existed in the golint are
turned off by default (ST1000, ST1003, ST1016), or removed. Users
can turn them on if want, by supplying -checks as lintFlags.
Unlike golint, staticcheck reports only compile errors and does
not show other lint errors if compile errors are present. Because
the compile errors will be also detected by the language server
or by the buildOnSave/vetOnSave checks and the extension will
deduplicate them, it may look to users as if the linter wasn't
running - I am not sure how much this will bother users yet.

Fixes golang/vscode-go#189
Updates #38968

Change-Id: Ie9334867aef3673aed01d7eaf757966486178dbc
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/279212
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>