tree fb19dd14041f6f53bd365b770b614e6fff3c8a7d
parent 7f568957363ec5c4c263b6575e132d99d728c720
author Hana <hyangah@gmail.com> 1611240075 -0500
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1611256493 +0000

src/goLanguageServer: partial revert of cl/280601

This partially reverts commit 4c91c3874bccaf659af616627ba1deefc3a35667.

In https://go-review.googlesource.com/c/vscode-go/+/280601,
we tried to remove the languageServerExperimentalFeatures setting
because gopls's diagnostics feature is no longer in its experimental
state and that was the only flag left in this setting.

However, we learned some users depend on this flag because the
extension turns off buildOnSave and vetOnSave features when gopls's
diagnostics is used and they need to run custom vet analyzers.
This is not ideal and the extension shouldn't prevent users from
running their custom analyzers. That needs more investigation and
experiment.

For now, we rollback the change, but place the deprecation notice.

Update golang/vscode-go#50
Fixes golang/vscode-go#1110

Change-Id: I376692b152d3011aaa8da7a1b5121ba33e2188b6
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/285253
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>