tree 37cc2670444c6978d2631cefae32d056008af427
parent 9b537762c5946f288e6d3247c265257fb81ec0ef
author Hana <hyangah@gmail.com> 1612044200 -0500
committer Hyang-Ah Hana Kim <hyangah@gmail.com> 1612381864 +0000

[release] src/goLanguageServer: protect language restart with mutex

We have used the languageServerStartInProgress flag to prevent
issuing another language start request while the previous language
start up process is in progress and is blocked. This prevented
the race of multiple language start calls. However, this can cause
important language client restart request to be skipped. Consider
this scenario:

- user modifies the setting to enable gopls and that triggers a call to
  startLanguageServerWithFallback. While this is waiting on
  startLanguageServer that will run with cfg.enabled = true.
- user modifies the stting to disable gopls, and that triggers another
  call to startLanguageServerWithFallback.
- the second startLanguageServerWithFallback will skip startLanguageServer
  because languageServerStartInProgress is true.
- As a result, we will fail to disable the language server.

This change fixes the issue by using a new Mutex to protect
startLanguageServer. With the change, the second call won't skip
startLanguageServer, but will be resumed when the previous
startLanguageServer call is finished.

This change also fixes the bug in src/goStatus that produced incorrect
language server status icon when language server is disabled.

Fixes golang/vscode-go#1132

Change-Id: I4435d41b843032ff8f675ea95aac002d9ba79b4b
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/288352
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
(cherry picked from commit 1ad5c33383f743d0a41ff0e401fdcab58ffcd056)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/289234